SDK/DSL: Fix bug when using PipelineParam in pvc of PipelineVolume
#2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no `name` is provided to PipelineVolume constructor, a custom name is generated. It relies on `json.dumps()` of the struct after getting converted to dict. When `pvc` is provided and `name` is not, the following error is raised: TypeError: Object of type PipelineParam is not JSON serializable This commit fixes it and extends tests to catch it.
Ark-kun
reviewed
Sep 4, 2019
| # Testing json.dumps() when pvc is a PipelineParam to avoid | ||
| # `TypeError: Object of type PipelineParam is not JSON serializable` | ||
| param = PipelineParam(name="foo") | ||
| vol3 = PipelineVolume(pvc=param) |
There was a problem hiding this comment.
Does this line just verify that the code does not crash?
There was a problem hiding this comment.
Yes, I thought it is not necessary to test the result as well (since naming is already tested in the previous lines).
Is it sufficient? Do you think we should test it in a different way?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Update pull request template Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Publish v0.8.0 release Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Add step to describe pods after e2e test failure Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Set default install mode to Serverless Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1402 introduced the following bug:
If no
nameis provided toPipelineVolumeconstructor, a custom name is generated. It relies onjson.dumps()of the struct after getting converted to dict.When
pvcis provided andnameis not, the following error is raised:This PR fixes it and extends tests to catch it.
This change is