Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #196

Closed
wants to merge 10 commits into from

Conversation

@hmtai
Copy link
Member

commented Aug 5, 2019

use multi stage to build image

#195

use multi stage to build image
@googlebot

This comment has been minimized.

Copy link

commented Aug 5, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot k8s-ci-robot requested review from andreyvelich and gaocegege Aug 5, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link

commented Aug 5, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign gaocegege
You can assign the PR to them by writing /assign @gaocegege in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Aug 5, 2019

Hi @hmtai. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Dockerfile Outdated
@@ -1,6 +1,17 @@
FROM golang:latest AS build-image

This comment has been minimized.

Copy link
@gaocegege

gaocegege Aug 5, 2019

Member

I think we should avoid using latest image.

This comment has been minimized.

Copy link
@hmtai

hmtai Aug 5, 2019

Author Member

Yes,use go version 1.12.

@gaocegege

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

/ok-to-test

Thanks for your contribution! 🎉 👍

Please sign the CLA, thanks.

@gaocegege

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

Error logs of CI is here: https://paste.ubuntu.com/p/JwCfpc9vdQ/

change go version to golang 1.12.
@coveralls

This comment has been minimized.

Copy link

commented Aug 5, 2019

Coverage Status

Coverage remained the same at 85.281% when pulling 6fe26c0 on hmtai:patch-1 into ca2c9c4 on kubeflow:master.

@johnugeorge

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@hmtai

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

@googlebot I signed it!)

@hmtai

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

/retest

hmtai added 7 commits Aug 6, 2019
@hmtai

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

Close it and create PR 198.

@hmtai hmtai closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.