/tf-operator

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Pods directly instead of using Job controllers #325

Closed
jlewi opened this Issue Jan 18, 2018 · 7 comments

Comments

Assignees

@ScorpioCPH ScorpioCPH

Labels
difficulty/medium kind/enhancement priority/p1
Projects
None yet
Milestone
  Kubecon Europe
6 participants
@jlewi @ScorpioCPH @gaocegege @vishh @DjangoPeng @k8s-ci-robot
@jlewi
Copy link
Collaborator

jlewi commented Jan 18, 2018

Consensus in #45 was that we should manage the pods directly. Opening this issue to track that work.

This was referenced Jan 18, 2018

Closed
Closed

@DjangoPeng DjangoPeng added the kind/enhancement label Jan 18, 2018

@ScorpioCPH

This comment has been minimized.

Sign in to view
Copy link
Member

ScorpioCPH commented Jan 19, 2018

Hi, folks, I will pick up this if nobody working on this :)
@jlewi

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

jlewi commented Jan 19, 2018

that would be great!

@jlewi jlewi assigned ScorpioCPH Jan 19, 2018

@gaocegege

This comment has been minimized.

Sign in to view
Copy link
Member

gaocegege commented Jan 19, 2018

@ScorpioCPH

Awesome! And I think it is hard to decouple #314 and this issue 🤔 Would you file one PR for these two issues together?

@jlewi jlewi referenced this issue Jan 20, 2018

Open

Prevent scheduling deadlocks #165

@ScorpioCPH ScorpioCPH referenced this issue Jan 24, 2018

Merged

Create Pod instead of Job #344

@jlewi jlewi added this to the Kubecon Europe milestone Jan 25, 2018

@vishh

This comment has been minimized.

Sign in to view
Copy link

vishh commented Feb 15, 2018

Just FYI: @kow3ns and I have been noodling on the idea of a stateful Job that would benefit TF Training Operator. Managing pods outside of existing curated controllers is a risky proposition IMHO, but might be a good stop gap solution.
We will post some updates once we get around to having some concrete designs on that.
@gaocegege

This comment has been minimized.

Sign in to view
Copy link
Member

gaocegege commented Feb 16, 2018

@vishh We can discuss it in the issue #45

@gaocegege gaocegege added the difficulty/medium label Feb 16, 2018

jlewi added a commit that referenced this issue Mar 5, 2018

@ScorpioCPH @jlewi
Create pod instead of job (#344) 
This PR is a part of #325:

rename jobName() to genName()
create Pod instead of Job

TODOs (in another PR):

use controller.PodControlInterface and CreatePodsWithControllerRef to create Pod
Listen Pod CRUD and update TFJob status which descried in #314
Loading status checks…
6706903

Jimexist pushed a commit to Jimexist/tf-operator that referenced this issue Mar 7, 2018

@ScorpioCPH Jiayu Liu
Create pod instead of job (kubeflow#344) 
This PR is a part of kubeflow#325:

rename jobName() to genName()
create Pod instead of Job

TODOs (in another PR):

use controller.PodControlInterface and CreatePodsWithControllerRef to create Pod
Listen Pod CRUD and update TFJob status which descried in kubeflow#314
de82ac0

@jlewi jlewi added the priority/p1 label Mar 7, 2018

@jlewi

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

jlewi commented Mar 7, 2018

@ScorpioCPH #344 is merged. Can we close this? Or is there more work to be done?
@ScorpioCPH

This comment has been minimized.

Sign in to view
Copy link
Member

ScorpioCPH commented Mar 7, 2018

/close

@k8s-ci-robot k8s-ci-robot closed this Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment