New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of TensorBoard replica #347

Closed
jlewi opened this Issue Jan 25, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@jlewi
Copy link
Collaborator

jlewi commented Jan 25, 2018

I think we should consider getting rid of TensorBoard replica in TFJob.

This was a bit of a hack to simplify TB management by tying the lifetime of TensorBoard to the lifetime of the TFJob.

I think there are better solutions though

  • The UI can make it easy to launch/manage all the TB jobs
  • TB is moving to a model where the UI is stateless and backed by a DB tensorflow/tensorboard#92
  • We could launch the TBJob separately but set owner reference to a TFJob.

I think its easy to forget to set logDir so people will often want to launch TB separately anyway.

@jlewi jlewi added this to the Kubecon Europe milestone Jan 25, 2018

@gaocegege gaocegege self-assigned this Feb 16, 2018

jlewi added a commit that referenced this issue Feb 27, 2018

Remove TensorBoard related code in operator (#391)
Ref #347

Blocked until CI is running again.

PS: Dashboard code is not changed.

Signed-off-by: Ce Gao ce.gao@outlook.com

@gaocegege gaocegege closed this Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment