feat: optimize code #890
Merged
feat: optimize code #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis tests have failedHey @zjj2wry, 2nd Buildgo build -o tf-operator.v2 github.com/kubeflow/tf-operator/cmd/tf-operator.v2gometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"3rd Buildgo build -o tf-operator.v2 github.com/kubeflow/tf-operator/cmd/tf-operator.v2gometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"TravisBuddy Request Identifier: 6ae20910-fd66-11e8-9fed-e5e5b8602491 |
|
/retest |
gaocegege
approved these changes
Dec 12, 2018
|
/test kubeflow-tf-operator-presubmit |
|
/retest |
|
/test kubeflow-tf-operator-presubmit |
|
/retest |
zjj2wry
changed the title
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gaocegege
reviewed
Dec 17, 2018
| @@ -279,9 +284,6 @@ func (tc *TFController) syncTFJob(key string) (bool, error) { | |||
| if err != nil { | |||
| return false, err | |||
| } | |||
| if len(namespace) == 0 || len(name) == 0 { | |||
| return false, fmt.Errorf("invalid tfjob key %q: either namespace or name is missing", key) | |||
There was a problem hiding this comment.
Actually, I am not sure why we could remove the validation here.
There was a problem hiding this comment.
func SplitMetaNamespaceKey will check it. And we can not create/update tfjob metadata let tfjob's namespace or name be empty
|
/test kubeflow-tf-operator-presubmit |
|
@gaocegege i squash commits，waiting for CI, I feel like this will pass, haha |
|
/test kubeflow-tf-operator-presubmit |
|
@gaocegege ready go，ptal |
|
/lgtm |
|
@johnugeorge thanks, i will create a pr fix it ~ |
|
@zjj2wry Thanks haha 🍻 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is