Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when conditions is empty. #1185

Merged
merged 2 commits into from Nov 13, 2020
Merged

Conversation

Corea
Copy link
Contributor

@Corea Corea commented Aug 4, 2020

No description provided.

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @Corea. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @jinchihe

@coveralls
Copy link

coveralls commented Aug 4, 2020

Coverage Status

Coverage remained the same at 96.667% when pulling 2feed83 on Corea:master into 394a7da on kubeflow:master.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 4, 2020
@Corea
Copy link
Contributor Author

Corea commented Aug 4, 2020

I also fixed the same errors on other files. @gaocegege

@jinchihe
Copy link
Member

jinchihe commented Aug 4, 2020

@Corea Thanks. Would you please append the error when the conditions is empty? I think for now, the code will return [] if the conditions is empty. Thanks.

@gaocegege
Copy link
Member

/ok-to-test

@k8s-ci-robot
Copy link

@Corea: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-tf-operator-presubmit 2feed83 link /test kubeflow-tf-operator-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jinchihe
Copy link
Member

jinchihe commented Aug 7, 2020

@Corea The CI problem already fixed, would you please rebase?

@Corea
Copy link
Contributor Author

Corea commented Aug 11, 2020

@Corea Thanks. Would you please append the error when the conditions is empty? I think for now, the code will return [] if the conditions is empty. Thanks.

TF Job doesn't have any information about status or condition sometimes, especially just after TF Job started, so the code should return [] or wait for complete information. How do you think?

@Corea The CI problem already fixed, would you please rebase?

Okay, I'll do it at the end!

@gaocegege
Copy link
Member

Hi, any update here?

@Corea
Copy link
Contributor Author

Corea commented Nov 12, 2020

Could you answer my question? @jinchihe

@jinchihe
Copy link
Member

@Corea I'm OK.

/lgtm
/approve

@gaocegege
Copy link
Member

/approve

Thanks for your contribution! 🎉 👍

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Corea, gaocegege, jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6c58dcb into kubeflow:master Nov 13, 2020
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants