Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example for mxnet and pytorch #1373

Merged
merged 1 commit into from Aug 18, 2021

Conversation

DeliangFan
Copy link
Contributor

related-issue: #1366

@aws-kf-ci-bot
Copy link
Contributor

Hi @DeliangFan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnugeorge
Copy link
Member

/ok-to-test

@johnugeorge
Copy link
Member

Can you fix the directory structure? There is. examples folder in examples /mxnet

@DeliangFan
Copy link
Contributor Author

Can you fix the directory structure? There is. examples folder in examples /mxnet

hi, johnugeorge thanks for reviewing, it has been fixed

@johnugeorge
Copy link
Member

Are there any changes from the examples in respective repos?

@DeliangFan
Copy link
Contributor Author

repos

I just modified the mxnet structure.

@johnugeorge
Copy link
Member

johnugeorge commented Aug 17, 2021

I meant, are there any changes in example code?

@DeliangFan
Copy link
Contributor Author

I meant, are there any changes in example code?

tf-operator/examples/tensorflow/tf_sample/Makefile
tf-operator/examples/tensorflow/distribution_strategy/estimator-API/Makefile

made a bit changes.

@DeliangFan
Copy link
Contributor Author

DeliangFan commented Aug 17, 2021

I meant, are there any changes in example code?

the only diff

+ CHANGED_FILES := $(shell git diff-files --relative=tensorflow/tf_sample)
 - CHANGED_FILES := $(shell git diff-files --relative=examples/tf_sample)

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this @DeliangFan!
I think /examples/crd can be deleted.

examples/mxnet/train/Dockerfile Outdated Show resolved Hide resolved
examples/mxnet/tune/auto-tuning.py Outdated Show resolved Hide resolved
examples/mxnet/tune/mx_job_tune_gpu_v1beta1.yaml Outdated Show resolved Hide resolved
examples/pytorch/bert/README.md Outdated Show resolved Hide resolved
examples/pytorch/bert/pytorch_job_bert.yaml Outdated Show resolved Hide resolved
@google-cla
Copy link

google-cla bot commented Aug 17, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@andreyvelich
Copy link
Member

@googlebot I consent.

@DeliangFan
Copy link
Contributor Author

@andreyvelich thanks for reviewing, a new patch has been pushed.

examples/mxnet/train/byteps_dist_gpu_v1beta1.yaml Outdated Show resolved Hide resolved
examples/mxnet/train/mx_job_dist_gpu_v1beta1.yaml Outdated Show resolved Hide resolved
examples/mxnet/tune/README.md Outdated Show resolved Hide resolved
examples/pytorch/mnist/Makefile Outdated Show resolved Hide resolved
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@DeliangFan
Copy link
Contributor Author

@Jeffwan , thanks a lot! A new patch has been pushed.

@Jeffwan
Copy link
Member

Jeffwan commented Aug 18, 2021

@Jeffwan , thanks a lot! A new patch has been pushed.

Thanks! overall looks good to me. hold it for other reviewers. @johnugeorge @andreyvelich

/lgtm

@johnugeorge
Copy link
Member

Looks great
Thanks @DeliangFan

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants