Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website home page should not mention Ambassador #1333

Closed
sarahmaddox opened this issue Nov 11, 2019 · 5 comments
Closed

Website home page should not mention Ambassador #1333

sarahmaddox opened this issue Nov 11, 2019 · 5 comments
Labels

Comments

@sarahmaddox
Copy link
Collaborator

@sarahmaddox sarahmaddox commented Nov 11, 2019

The website home page mentions Ambassador, but I think Kubeflow v0.7 onwards no longer uses Ambassador:
https://www.kubeflow.org/

@issue-label-bot

This comment has been minimized.

Copy link

@issue-label-bot issue-label-bot bot commented Nov 11, 2019

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 0.75. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the kind/bug label Nov 11, 2019
@sarahmaddox

This comment has been minimized.

Copy link
Collaborator Author

@sarahmaddox sarahmaddox commented Nov 11, 2019

@jlewi Is it correct to say we should remove Ambassador from the home page? If yes, I can get this done during an upcoming doc fixit this week.

@jlewi

This comment has been minimized.

Copy link
Contributor

@jlewi jlewi commented Nov 12, 2019

The mention I see as "We also integrate with Istio and Ambassador for ingress,"
We still use Ambassador in some cases as part of external authentication so its not entirely untrue.

It would be good to have a way of crediting all the technologies and projects we build upon without getting into the specifics.

@sarahmaddox

This comment has been minimized.

Copy link
Collaborator Author

@sarahmaddox sarahmaddox commented Nov 12, 2019

Thanks Jeremy, that's good enough for now. I'll close this issue.

/close

@k8s-ci-robot

This comment has been minimized.

Copy link

@k8s-ci-robot k8s-ci-robot commented Nov 12, 2019

@sarahmaddox: Closing this issue.

In response to this:

Thanks Jeremy, that's good enough for now. I'll close this issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.