Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WtD fixit: Readability improvements for Securing Your Clusters #1367

Closed
sxbfundi opened this issue Nov 14, 2019 · 4 comments

Comments

@sxbfundi
Copy link
Contributor

@sxbfundi sxbfundi commented Nov 14, 2019

https://www.kubeflow.org/docs/gke/private-clusters/

  • Expand abbreviations on first use.
  • Add colons at end of all intro sentences.
  • Add intro sentences where missing.
  • Consider breaking up the very long numbered list.
@issue-label-bot

This comment has been minimized.

Copy link

@issue-label-bot issue-label-bot bot commented Nov 14, 2019

Issue-Label Bot is automatically applying the label kind/feature to this issue, with a confidence of 0.88. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

sxbfundi added a commit to sxbfundi/website that referenced this issue Nov 14, 2019
Work in progress. There's still more work to be done to fix all of the issues in kubeflow#1367.
k8s-ci-robot added a commit that referenced this issue Nov 14, 2019
Work in progress. There's still more work to be done to fix all of the issues in #1367.
@sarahmaddox

This comment has been minimized.

Copy link
Collaborator

@sarahmaddox sarahmaddox commented Nov 14, 2019

Pull #1403 addresses this issue, but there are still more fixes to make - see the PR comment.

@sarahmaddox

This comment has been minimized.

Copy link
Collaborator

@sarahmaddox sarahmaddox commented Nov 16, 2019

Thanks for the updates in your PR, @sxbfundi! I'll close this issue now, since we've finished the fixit. We'll tackle the remaining tidy-ups in our next fixit or random tech-writer read-through.

/close

@k8s-ci-robot

This comment has been minimized.

Copy link

@k8s-ci-robot k8s-ci-robot commented Nov 16, 2019

@sarahmaddox: Closing this issue.

In response to this:

Thanks for the updates in your PR, @sxbfundi! I'll close this issue now, since we've finished the fixit. We'll tackle the remaining tidy-ups in our next fixit or random tech-writer read-through.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.