Use kubeconfig on desktop #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For requests against an alternative cluster only the server url was used, but not the passed in url. Therefor the cluster status works, but the url must be changed to '' after this bug fix.
Instead of manual adding clusters to kubenav on desktop, the kubeconfig file of the user is used now. At the start of the server component, the local kubeconfig file is parsed. To use the clusters from the kubeconfig the server implements two new endpoints cluster and clusters. These endpoints returning the current context and all clusters from the kubeconfig file. While the kubeconfig file is used now, it is not possible anymore to add clusters manual to kubenav. But all cloud providers are supported on desktop now. When kubenav is started the current context and namespace is automatically set as initial selected cluster.
Since we are using the local kubeconfig file now, we had to adjust the electron logic to show and switch clusters. Now we are saving the selected cluster in localStorage and check if the name form localStorage exists in the loaded clusters. When the name exists this cluster will be used instead of the loaded active cluster from the current context.
Instead of the last active cluster in kubenav, we use the cluster from the current context as active cluster when kubenav is started.
Since wwe are using the local kubeconfig file, the edit and delete options are not needed on desktop.
This was referenced Feb 21, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding clusters manual to kubenav on desktop, the kubeconfig from
~/.kube/configis used now. Therefor the option to add clusters manual was removed.With this approach all cloud providers like Google Cloud (GKE) and Amazon Web Services (EKS) should be supported on desktop for now.
Closes #13.
Clean up:
segment-wrapperCSS class, which was only used by the old screen for adding a cluster.