Fix bugs regarding authentication #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For larger screens (tablets), the Sign In button was hidden and the user had to scroll to click the button. Now the button should be visible for all display sizes. For that we add a new hook useWindowHeight, which returns the current height of the window. If the window height is to small to display the icon and the Sign In button we hide the icon. We also rename the Sign In button to Unlock.
Instead of clicking the unlock button, the user is automatically ask to unlock the app via Face ID / Touch ID. This means the user only must click the unlock button, when the authentication fails.
This was referenced Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263 and #264.