From 0bd7c7e598761ed06f877cbe5d0cb0a46ad07f60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=BC=A0=E7=A5=96=E5=BB=BA?= Date: Sat, 11 Feb 2023 15:59:36 +0800 Subject: [PATCH] perf: use empty struct to reduce memory usage (#2327) --- pkg/controller/pod.go | 4 ++-- pkg/util/named_port.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/controller/pod.go b/pkg/controller/pod.go index 95ddafac57c..96f9185696b 100644 --- a/pkg/controller/pod.go +++ b/pkg/controller/pod.go @@ -65,7 +65,7 @@ func (n *NamedPort) AddNamedPortByPod(pod *v1.Pod) { if _, ok := n.namedPortMap[ns]; ok { if _, ok := n.namedPortMap[ns][port.Name]; ok { if n.namedPortMap[ns][port.Name].PortId == port.ContainerPort { - n.namedPortMap[ns][port.Name].Pods[podName] = "" + n.namedPortMap[ns][port.Name].Pods[podName] = struct{}{} } else { klog.Errorf("named port %s has already be defined with portID %d", port.Name, n.namedPortMap[ns][port.Name].PortId) @@ -77,7 +77,7 @@ func (n *NamedPort) AddNamedPortByPod(pod *v1.Pod) { } n.namedPortMap[ns][port.Name] = &util.NamedPortInfo{ PortId: port.ContainerPort, - Pods: map[string]string{podName: ""}, + Pods: map[string]struct{}{podName: {}}, } } } diff --git a/pkg/util/named_port.go b/pkg/util/named_port.go index e2ad762b059..880916cd1ee 100644 --- a/pkg/util/named_port.go +++ b/pkg/util/named_port.go @@ -2,5 +2,5 @@ package util type NamedPortInfo struct { PortId int32 - Pods map[string]string // pods named port belong to + Pods map[string]struct{} }