fix: for existing nic, no need to set the port type to internal #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oilbeater <liumengxinfly@gmail.com>
oilbeater
force-pushed
the
fix/mirror
branch
from
52ed53a
to
59151f4
Compare
zhangzujian
approved these changes
Sep 25, 2023
oilbeater
added a commit
that referenced
this pull request
Sep 25, 2023
Signed-off-by: oilbeater <liumengxinfly@gmail.com>
oilbeater
added a commit
that referenced
this pull request
Sep 25, 2023
Signed-off-by: oilbeater <liumengxinfly@gmail.com>
wenwenxiong
pushed a commit
to wenwenxiong/kube-ovn
that referenced
this pull request
Sep 28, 2023
…ovn#3243) Signed-off-by: oilbeater <liumengxinfly@gmail.com> Signed-off-by: xiongww <xiongww@chinatelecom.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #3225
WHAT
🤖 Generated by Copilot at 52ed53a
Improve mirror port creation and configuration for OVS bridge. Use netlink package to check mirror interface existence and reduce OVS commands. Affect file
pkg/daemon/ovs.go.🤖 Generated by Copilot at 52ed53a
HOW
🤖 Generated by Copilot at 52ed53a
configureGlobalMirrorandconfigureEmptyMirrorfunctions to skipadd-portcommand if mirror interface already exists (link)