Merged
Conversation
Without this patch, we use WriterLevel, which spawns go routines. As we do it at every call of the util commands, we spawn goroutines at every check. This is a problem as it leads to memory management issues. This fixes it by using a buffer for stdout and stderr, then logging the results after the command was executed. To make sure the logging happened at the same place, I inlined the code from utils. This results in duplicated the code. However, this is not a big problem as: - It makes the code more readable - The implementation between checkers and rebooters _ARE_ different -- One definitely NEEDS privileges, while the other does not... Which could lead to later improvements. Removing a "utils" package is not really a big deal (it is kinda a win in itself, as it is an anti-pattern), as the test coverage was kept. Partial-Fix: kubereboot#1004 Fixes: kubereboot#1013 Signed-off-by: Jean-Philippe Evrard <open-source@a.spamming.party>
Collaborator
Author
|
@jonaz Could you check this, please? |
Merged
jonaz
reviewed
Nov 6, 2024
jonaz
reviewed
Nov 6, 2024
Without this, we are loosing features based on previous logrus implementation. Now, we will log the stdout and stderr for each call. Next to this, we ensure the call of the log. methods will be ready for the switch to get rid of logrus in the future. Signed-off-by: Jean-Philippe Evrard <open-source@a.spamming.party>
evrardjp
force-pushed
the
fix_goroutine_leak
branch
from
38cada7 to
94e7346
Compare
Collaborator
Author
|
@jonaz can you have a second look please? |
Collaborator
Author
|
I tested commit 1 on a new env. It has good results. |
|
@evrardjp LGTM 👍 |
jonaz
approved these changes
Nov 6, 2024
dholbach
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch, we use WriterLevel, which spawns go routines. As we do it at every call of the util commands, we spawn goroutines at every check.
This is a problem as it leads to memory management issues.
This fixes it by using a buffer for stdout and stderr, then logging the results after the command was executed.
To make sure the logging happened at the same place, I inlined the code from utils. This results in duplicated the code.
However, this is not a big problem as:
Removing a "utils" package is not really a big deal (it is kinda a win in itself, as it is an anti-pattern), as the test coverage was kept.
Partial-Fix: #1004
Fixes: #1013