Merged
Conversation
Without this, the CI would automatically point DH_ORG to kubereboot/kured on ghcr, instead of pointing to the owner of the repo. This makes the CI smoother. Signed-off-by: Jean-Philippe Evrard <open-source@a.spamming.party>
We can't move to use 1.22 yet, so we'll ignore this one. Signed-off-by: Jean-Philippe Evrard <open-source@a.spamming.party>
Without this, some CI jobs are flaky or slow due to the following issues: - Triggering a reboot cause an unrecoverable boot loop. This fixes it by restarting the containers that are incorrectly exited. - API server is down while operations happen. This fixes it by ensuring at least one API server is up. In this case, we don't add a reboot marker on the unique api server. - The amount of nodes in a test environment is larger than necessary. This fixes it by ensuring two nodes are required to reboot. This is enough for concurrency, and for the e2e testing. - The wait time between operations is high, and can cause a heartbeat to be missed in the check script. This fixes it by checking more often, at the expense of more logging. This is compensated by increasing the amount of tries. Signed-off-by: Jean-Philippe Evrard <open-source@a.spamming.party>
Collaborator
Author
|
All tests passed without issues in 6minutes and a half. I think that's better than what we had :) |
jackfrancis
approved these changes
Oct 3, 2024
Collaborator
jackfrancis
left a comment
jackfrancis
left a comment
There was a problem hiding this comment.
This all seems sane, great chop 🪵 carry 🪣 vibes here.
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes CI for forks, improves the behaviour on 1.21 (CVE present won't be fixed until a 1.22 update of golang), and accelerates the development/testing on github.