New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project-scoped API endpoints for OpenStack #5489
Add project-scoped API endpoints for OpenStack #5489
Conversation
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: cd53960253a9eb21cadcf83110c87349dbc0f0f4
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds project-scoped API endpoints for fetching OpenStack information, which means that it is now possible to use presets with project limitations to provide credentials for the request.
Unfortunately, for two Openstack API endpoints I had to rename multi-tenancy headers (
ProjectID
->OpenstackProjectID
,Project
->OpenstackProject
, etc) because it was shadowing the field for the KKP project IDs that is part ofcommon.ProjectReq
. That's not ideal, but I couldn't find a better solution. IMHO fields that include generic multi-tenancy terms like "project" should always be prefixed if they refer to a concept outside of the system that you are working on.Which issue(s) this PR fixes:
Fixes #5130
What type of PR is this?
/kind feature
/kind api-change
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: