Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idempotent install #663

Merged
merged 4 commits into from Sep 19, 2019
Merged

Idempotent install #663

merged 4 commits into from Sep 19, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Sep 16, 2019

What this PR does / why we need it:

make kubeone install be able to finish if interrupted.

kubeone install is idempotent now

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Sep 16, 2019

/retest

1 similar comment
@kron4eg
Copy link
Member Author

kron4eg commented Sep 16, 2019

/retest

@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Sep 17, 2019

/retest

xmudrii
xmudrii reviewed Sep 17, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of questions.

pkg/state/context.go Outdated Show resolved Hide resolved
pkg/state/context.go Show resolved Hide resolved
pkg/state/context.go Outdated Show resolved Hide resolved
pkg/upgrader/upgrade/upgrade.go Outdated Show resolved Hide resolved
@kron4eg
Make kubeone install idempotent
1843ce6 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Extract geenerate token
9304204 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Create State.JoinToken in state.New()
ac64d06 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2019
@kron4eg
Remove State.lock
c10314d 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
xmudrii
xmudrii approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 596e22d1249b983d4e7c3aced92604af51e89e2f

@kubermatic-bot kubermatic-bot merged commit ca4d05f into master Sep 19, 2019
@kubermatic-bot kubermatic-bot deleted the idempotent-install branch September 19, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kron4eg @kubermatic-bot @xmudrii