New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DigitalOcean CCM #11464
Add support for DigitalOcean CCM #11464
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pre-kubermatic-mla-e2e |
/override pre-kubermatic-test-integration vSphere/VPN is broken yet again. |
@xrstf: Overrode contexts on behalf of xrstf: pre-kubermatic-test-integration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pre-kubermatic-e2e-do-centos-1.25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{"level":"error","time":"2022-11-30T18:32:38.480Z","logger":"kkp-kubernetes-controller","caller":"kubernetes/cluster_controller.go:273","msg":"Reconciling failed","cluster":"kkp-1598020224408358912-56qg6","error":"failed to reconcile cluster: failed to ensure Deployment cluster-kkp-1598020224408358912-56qg6/digitalocean-cloud-controller-manager: failed to create *v1.Deployment 'cluster-kkp-1598020224408358912-56qg6/digitalocean-cloud-controller-manager': Deployment.apps "digitalocean-cloud-controller-manager" is invalid: spec.template.spec.containers[2].name: Duplicate value: "openvpn-client"","errorCauses":[{"error":"failed to reconcile cluster: failed to ensure Deployment cluster-kkp-1598020224408358912-56qg6/digitalocean-cloud-controller-manager: failed to create *v1.Deployment 'cluster-kkp-1598020224408358912-56qg6/digitalocean-cloud-controller-manager': Deployment.apps "digitalocean-cloud-controller-manager" is invalid: spec.template.spec.containers[2].name: Duplicate value: "openvpn-client""}]}
/test pre-kubermatic-e2e-do-centos-1.25 |
/test pre-kubermatic-e2e-do-centos-1.25 |
Unfortunately during rebase, I unknowingly dropped some of my changes. Everything should be fine now. |
Co-Authored-By: Sang Woo Bae <sang@kubermatic.com> Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
/test pre-kubermatic-e2e-do-centos-1.25 |
/retest |
/retest |
/lgtm |
LGTM label has been added. Git tree hash: 1ee287ce8cd7c1ce84de32f121113df1e47ed2fe
|
Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com
Co-Authored-By: Sang Woo Bae sang@kubermatic.com
What this PR does / why we need it:
This PR adds support for DigitalOcean CCM(digitalocean-cloud-controller-manager).
Which issue(s) this PR fixes:
Fixes #8847
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: