Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DigitalOcean CCM #11464

Merged
merged 1 commit into from Dec 1, 2022
Merged

Add support for DigitalOcean CCM #11464

merged 1 commit into from Dec 1, 2022

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Nov 29, 2022

Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com
Co-Authored-By: Sang Woo Bae sang@kubermatic.com

What this PR does / why we need it:
This PR adds support for DigitalOcean CCM(digitalocean-cloud-controller-manager).

Which issue(s) this PR fixes:

Fixes #8847

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add support for DigitalOcean external CCM

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Nov 29, 2022
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 29, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2022
@ahmedwaleedmalik
Copy link
Member Author

/retest

@ahmedwaleedmalik
Copy link
Member Author

/test pre-kubermatic-mla-e2e

@xrstf
Copy link
Contributor

xrstf commented Nov 30, 2022

/override pre-kubermatic-test-integration

vSphere/VPN is broken yet again.

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pre-kubermatic-test-integration

In response to this:

/override pre-kubermatic-test-integration

vSphere/VPN is broken yet again.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrstf
Copy link
Contributor

xrstf commented Nov 30, 2022

/test pre-kubermatic-e2e-do-centos-1.25

Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{"level":"error","time":"2022-11-30T18:32:38.480Z","logger":"kkp-kubernetes-controller","caller":"kubernetes/cluster_controller.go:273","msg":"Reconciling failed","cluster":"kkp-1598020224408358912-56qg6","error":"failed to reconcile cluster: failed to ensure Deployment cluster-kkp-1598020224408358912-56qg6/digitalocean-cloud-controller-manager: failed to create *v1.Deployment 'cluster-kkp-1598020224408358912-56qg6/digitalocean-cloud-controller-manager': Deployment.apps "digitalocean-cloud-controller-manager" is invalid: spec.template.spec.containers[2].name: Duplicate value: "openvpn-client"","errorCauses":[{"error":"failed to reconcile cluster: failed to ensure Deployment cluster-kkp-1598020224408358912-56qg6/digitalocean-cloud-controller-manager: failed to create *v1.Deployment 'cluster-kkp-1598020224408358912-56qg6/digitalocean-cloud-controller-manager': Deployment.apps "digitalocean-cloud-controller-manager" is invalid: spec.template.spec.containers[2].name: Duplicate value: "openvpn-client""}]}

@ahmedwaleedmalik
Copy link
Member Author

/test pre-kubermatic-e2e-do-centos-1.25

@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as draft November 30, 2022 19:02
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2022
@ahmedwaleedmalik
Copy link
Member Author

/test pre-kubermatic-e2e-do-centos-1.25

@ahmedwaleedmalik
Copy link
Member Author

Unfortunately during rebase, I unknowingly dropped some of my changes. Everything should be fine now.

@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as ready for review November 30, 2022 19:44
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2022
Co-Authored-By: Sang Woo Bae <sang@kubermatic.com>
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Copy link
Member Author

/test pre-kubermatic-e2e-do-centos-1.25

@ahmedwaleedmalik
Copy link
Member Author

/retest

@ahmedwaleedmalik
Copy link
Member Author

/retest

@xrstf
Copy link
Contributor

xrstf commented Dec 1, 2022

/lgtm
/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1ee287ce8cd7c1ce84de32f121113df1e47ed2fe

@kubermatic-bot kubermatic-bot merged commit b9e117a into kubermatic:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for DigitalOcean CCM in KKP
3 participants