Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new fields to externalcluster crd #11644

Merged
merged 2 commits into from Jan 10, 2023
Merged

add new fields to externalcluster crd #11644

merged 2 commits into from Jan 10, 2023

Conversation

imharshita
Copy link
Contributor

@imharshita imharshita commented Jan 9, 2023 •
edited

Signed-off-by: Harshita sharma harshita.sharma6174@gmail.com

What this PR does / why we need it: add new fields to externalcluster crd :

  • KubeOne Control Plane Region: This field will store and display KubeOne cluster region information.
  • Control Plane Version: This field is used in order to process desired version KubeOne Clusters using the KubeOne controller.
    Similar changes for AKS/EKS/GKE will be done in future PRs

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Adds `spec.version` and `spec.cloudSpec.kubeone.region` fields in External cluster CRD.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2023
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Jan 9, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imharshita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@imharshita imharshita force-pushed the k1-crd-new-fields branch 2 times, most recently from 28cb108 to 3982f03 Compare January 9, 2023 14:30
@imharshita
Copy link
Contributor Author

/retest

@imharshita
add new fields to externalcluster crd
8004f20 
Signed-off-by: Harshita sharma <harshita.sharma6174@gmail.com>
@imharshita imharshita requested review from ahmedwaleedmalik and xrstf and removed request for xrstf January 9, 2023 15:47
@imharshita
Copy link
Contributor Author

/retest

@imharshita imharshita requested a review from embik January 9, 2023 17:17
@imharshita
add additional information about added fields
2ab6256 
Signed-off-by: Harshita sharma <harshita.sharma6174@gmail.com>
@embik
Copy link
Member

embik commented Jan 10, 2023

Please add a release note in the PR description since this changes a CRD (which is user-facing), then we're good to go with this PR.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 10, 2023
@imharshita
Copy link
Contributor Author

Please add a release note in the PR description since this changes a CRD (which is user-facing), then we're good to go with this PR.

is added release-note enough or should I add more information

@embik
Copy link
Member

embik commented Jan 10, 2023 •
edited

Please add a release note in the PR description since this changes a CRD (which is user-facing), then we're good to go with this PR.

is added release-note enough or should I add more information

It's fine regarding information, however I believe the first path isn't correct (both changes are in the same structs, but the given paths are not the same) and you can remove the externalcluster part from it (i.e. .spec.something.something is enough since you mention what CRD has been updated).

@imharshita
Copy link
Contributor Author

Please add a release note in the PR description since this changes a CRD (which is user-facing), then we're good to go with this PR.

is added release-note enough or should I add more information

It's fine regarding information, however I believe the first path isn't correct (both changes are in the same structs, but the given paths are not the same) and you can remove the externalcluster part from it (i.e. .spec.something.something is enough since you mention what CRD has been updated).

path looks right, have removed externalcluster

@embik
Copy link
Member

embik commented Jan 10, 2023

Apologies for the path, I was confused and didn't read the diff carefully enough. My bad.

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2a2e3cf520c0ff89328eb786d83f81b05ee993d2

@kubermatic-bot kubermatic-bot merged commit 173ac4f into kubermatic:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

@ahmedwaleedmalik ahmedwaleedmalik Awaiting requested review from ahmedwaleedmalik

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imharshita @kubermatic-bot @embik