Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for installer to fail if a docker cluster still exists #11781

Merged
merged 2 commits into from Jan 30, 2023
Merged

Add validation for installer to fail if a docker cluster still exists #11781

merged 2 commits into from Jan 30, 2023

Conversation

embik
Copy link
Member

@embik embik commented Jan 27, 2023

What this PR does / why we need it:
We don't want to allow upgrading KKP if clusters with docker as container runtime since KKP 2.22 will only support Kubernetes 1.24+. As such, we want users to upgrade their container runtime before making the jump to KKP 2.22.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Upgrading KKP requires to change container runtime for all user clusters to containerd beforehand

Documentation:

NONE

@embik
Add validation for installer to fail if a docker cluster still exists
870c44c 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik requested a review from xrstf January 27, 2023 10:04
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 27, 2023
@embik
fix typo
f1f719c 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik added this to the KKP 2.22 milestone Jan 27, 2023
xrstf
xrstf approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2c3b07a9627e94a48b45ad52d34fdd917a23cacb

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@embik embik added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Jan 30, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Jan 30, 2023
@kubermatic-bot kubermatic-bot merged commit 7359bc4 into kubermatic:main Jan 30, 2023
@embik embik deleted the installer-check-for-docker-cr branch January 30, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@embik @kubermatic-bot @xrstf