Skip to content

Fix ini escaping #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 23, 2018
Merged

Fix ini escaping #370

merged 6 commits into from
Oct 23, 2018

Conversation

@mrIncompetent
Copy link
Contributor

@mrIncompetent mrIncompetent commented Oct 22, 2018

What this PR does / why we need it:
Fix ini escaping by going back to simple text templates as the used lib was not compatible.

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 22, 2018
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2018
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Oct 22, 2018

@mrIncompetent: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test 1206ac7 link /test test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mrIncompetent
Copy link
Contributor Author

mrIncompetent commented Oct 22, 2018

/test test

@cbeneke
Copy link
Contributor

cbeneke commented Oct 22, 2018

lgtm

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2018
@mrIncompetent
Copy link
Contributor Author

mrIncompetent commented Oct 23, 2018

/lgtm

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Oct 23, 2018

@mrIncompetent: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alvaroaleman
Copy link
Contributor

alvaroaleman commented Oct 23, 2018

/lgtm

@kubermatic-bot kubermatic-bot added lgtm Indicates that a PR is ready to be merged. labels Oct 23, 2018
@mrIncompetent
Copy link
Contributor Author

mrIncompetent commented Oct 23, 2018

/meow

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Oct 23, 2018

@mrIncompetent: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrIncompetent
Copy link
Contributor Author

mrIncompetent commented Oct 23, 2018

/woof

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Oct 23, 2018

@mrIncompetent: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrIncompetent
Copy link
Contributor Author

mrIncompetent commented Oct 23, 2018

/joke

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Oct 23, 2018

@mrIncompetent: Why do bears have hairy coats? Fur protection.

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alvaroaleman
alvaroaleman reviewed Oct 23, 2018
View reviewed changes
@alvaroaleman
Copy link
Contributor

alvaroaleman commented Oct 23, 2018

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2018
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2018
@alvaroaleman
Copy link
Contributor

alvaroaleman commented Oct 23, 2018

/lgtm
/hold cancel

@kubermatic-bot kubermatic-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 23, 2018
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Oct 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, mrIncompetent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,mrIncompetent]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit f71c642 into master Oct 23, 2018
@mrIncompetent mrIncompetent deleted the fix-ini-escaping branch October 23, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alvaroaleman alvaroaleman alvaroaleman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alvaroaleman alvaroaleman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrIncompetent @kubermatic-bot @cbeneke @alvaroaleman