Cherry Pick #2952 To Release 19 #3814
Conversation
…read entries with openConnection when running in IDE or a thin jar, it is ok, when running with a fat jar in server, new JarFile can not open and read the entries.
k8s-ci-robot
added
cncf-cla: yes
ryanjbaxter
changed the title
|
@brendanburns @yue9944882 this is another one for the Release-19 branch |
|
@ryanjbaxter thanks for the PR, but there are 5 commits in the original PR after the review, can you cherry-pick all of those commits? In particular, I want the change that requires that the |
In a fat jar, packageURL start with "nested:", not a fat jar, it start with "jar:". (cherry picked from commit ec7e7b9)
…eturn packageURL is not jar or nested, it would be return (cherry picked from commit 88ac227)
re import URLDecoder (cherry picked from commit de71d98)
…unit test) (cherry picked from commit f69bd5e)
k8s-ci-robot
added
size/S
|
@brendandburns Sure the additional commits should be there now |
|
/lgtm Thanks for the quick turn around. |
k8s-ci-robot
added
lgtm
|
looks like we need to rebase this PR after the above one get merged |
|
@yue9944882 yes! Will do after it is merged! |
…at-jar-fix-to-release-19
k8s-ci-robot
removed
the
lgtm
|
@brendandburns @yue9944882 I have rebased this PR can we run the build again? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, ryanjbaxter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ryanjbaxter I pushed a https://repo1.maven.org/maven2/io/kubernetes/client-java/19.0.2/ |
|
Excellent thank you! |
5 participants
Cherry pick #2952 to Release-19 branch