Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code generation to Kubernetes 1.22.2, Rev package to 0.16.0 #727

Merged
merged 4 commits into from Nov 7, 2021

Conversation

brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Oct 1, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes label Oct 1, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Oct 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved size/XXL labels Oct 1, 2021
@k8s-ci-robot k8s-ci-robot requested a review from drubin Oct 1, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase label Oct 7, 2021
@TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Oct 19, 2021

I tried to test this but ran into an issue, but the issue is something I've run into previously. Sometimes a CRD api gets skipped and it's Api client isn't generated.

I'll try to set this up with a vanilla kind cluster and test against that, instead of with a cluster with lots of CRDs, then report back.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase label Oct 21, 2021
@drubin
Copy link
Contributor

@drubin drubin commented Oct 24, 2021

@brendandburns requires a rebase as the tests don't seem to work with missing dependencies.

@brendandburns
Copy link
Contributor Author

@brendandburns brendandburns commented Nov 5, 2021

Rebased and ready to merge I think.

Thanks!

@drubin
Copy link
Contributor

@drubin drubin commented Nov 7, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit ab5fc88 into kubernetes-client:master Nov 7, 2021
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cncf-cla: yes lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants