Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript open API generator to handle the IntOrString type #741

Merged

Conversation

alex-bezek
Copy link
Contributor

@alex-bezek alex-bezek commented Nov 18, 2021

Resolves #666

The 1 main change here is the addition of the IntOrString type to the src/types.ts file. The rest is the result of running
GEN_ROOT=/home/alexbezek/code/gen npm run generate and running npm run build to verify it compiles

Depends on kubernetes-client/gen#213

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Nov 18, 2021

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no label Nov 18, 2021
@linux-foundation-easycla
Copy link

@linux-foundation-easycla linux-foundation-easycla bot commented Nov 18, 2021

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Nov 18, 2021

Welcome @alex-bezek!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L label Nov 18, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes and removed cncf-cla: no labels Nov 18, 2021
@brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Nov 19, 2021

/lgtm
/approve

Thank you for taking the time to do this!!

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 19, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Nov 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alex-bezek, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Nov 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit d44fa64 into kubernetes-client:master Nov 19, 2021
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cncf-cla: yes lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants