Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expires-on case on Azure auth #753

Merged
merged 2 commits into from Dec 11, 2021
Merged

Conversation

laudibert
Copy link
Contributor

@laudibert laudibert commented Dec 8, 2021

Fix for #752

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Dec 8, 2021

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linux-foundation-easycla
Copy link

@linux-foundation-easycla linux-foundation-easycla bot commented Dec 8, 2021

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no label Dec 8, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Dec 8, 2021

Welcome @laudibert!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S label Dec 8, 2021
@laudibert
Copy link
Contributor Author

@laudibert laudibert commented Dec 8, 2021

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes and removed cncf-cla: no labels Dec 8, 2021
@brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Dec 9, 2021

Thanks for the PR!

\lgtm
\approve

@laudibert
Copy link
Contributor Author

@laudibert laudibert commented Dec 10, 2021

Ah, sorry for the format error. Fixed now.

@brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Dec 10, 2021

\lgtm
\approve

@brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Dec 11, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 11, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Dec 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, laudibert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Dec 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6131bae into kubernetes-client:master Dec 11, 2021
8 checks passed
@laudibert
Copy link
Contributor Author

@laudibert laudibert commented Dec 12, 2021

Thanks @brendandburns , is there anything I can do to make a 0.16.2 be released with that PR included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cncf-cla: yes lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants