Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more quantity units #757

Merged

Conversation

wejendorp
Copy link
Contributor

@wejendorp wejendorp commented Dec 28, 2021

Adds support for missing decimal units: u, k, M, G, T, P and E.
Fixes multiplier for nano from 1e-8 to 1e-9.

Adds more units from #653, and should cover the full range of decimal units now.
Prevents the new top commands from crashing if any resource is using decimal units.

@linux-foundation-easycla
Copy link

@linux-foundation-easycla linux-foundation-easycla bot commented Dec 28, 2021

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Dec 28, 2021

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no label Dec 28, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Dec 28, 2021

Welcome @wejendorp!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M label Dec 28, 2021
Adds support for missing decimal units: u, k, M, G, T, P and E.
Fixes multiplier for nano from 1e-8 to 1e-9.
@wejendorp wejendorp force-pushed the quantityToScalar-units-653 branch from 458f93b to 25bda5f Compare Dec 28, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes and removed cncf-cla: no labels Dec 28, 2021
@@ -42,7 +42,7 @@ const mockedPodMetrics: PodMetricsList = {
window: '30s',
containers: [
{ name: 'nginx', usage: { cpu: '0', memory: '4012Ki' } },
{ name: 'sidecar', usage: { cpu: '140000000n', memory: '3012Ki' } },
{ name: 'sidecar', usage: { cpu: '1400000000n', memory: '3012Ki' } },
Copy link
Contributor Author

@wejendorp wejendorp Dec 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding missing 0 to make tests pass w/ the nano 1e-8 -> 1e-9 change.

@brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Dec 29, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 29, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Dec 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, wejendorp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Dec 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 39cd5a7 into kubernetes-client:master Dec 29, 2021
8 checks passed
@wejendorp
Copy link
Contributor Author

@wejendorp wejendorp commented Dec 29, 2021

@brendandburns when do you think it'll be possible to make a release from this?

@sorenmat
Copy link

@sorenmat sorenmat commented Jan 3, 2022

Please note I created this #758 since merging to master triggers a job that doesn't work

@brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Jan 4, 2022

@wejendorp I will push a release this week.

@wejendorp
Copy link
Contributor Author

@wejendorp wejendorp commented Jan 17, 2022

@wejendorp I will push a release this week.

@brendandburns bump, in case you forgot.

@mycrEEpy
Copy link

@mycrEEpy mycrEEpy commented Jan 18, 2022

A release would be super helpful as we are currently hitting the "Unknown suffix" exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cncf-cla: yes lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants