-
Notifications
You must be signed in to change notification settings - Fork 3.3k
add 'list_ingressroute_for_all_namespaces' method #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'list_ingressroute_for_all_namespaces' method #1454
Conversation
|
||
|
||
def delete_namespace(namespace_api, name): | ||
namespace_deleted = namespace_api.delete(name=name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
namespace_deleted is not used, do you need to assign to it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing. No, the variable namespace_deleted
is not required.
I've removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing. No, the variable namespace
is not required. I've removed it.
please squash the commits, otherwise looks good. |
e1480d8
to
eb952e7
Compare
Thank you. I've squashed the commits. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Priyankasaggu11929, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
As mentioned in the linked issue, there is a suggestion to implement a
list_ingressroute_for_all_namespaces
method, which is meant for listing all theingressroutes
resources across all the namespaces. This PR adds changes to implement the same.This new method,
list_ingressroute_for_all_namespaces
is analogous to executingkubectl get ingressroutes --all-namespaces
command.Besides, implementing the above method, the PR also include changes for demonstrating creation & deletion of k8s namespace resources using
dynamic client
. The methods implemented arecreate_namespace
&deleted_namespace
.Output of the script:
Which issue(s) this PR fixes:
Fixes #1388
Does this PR introduce a user-facing change?