drop python 2 support #1468

Priyankasaggu11929 · 2021-05-14T14:28:40Z

What type of PR is this?

/kind feature
/kind clean-up

What this PR does / why we need it:

The PR makes changes to drop support for Python 2 from the next release (v18.0.0). The changes includes:

drop Python 2 from master branch
make sure all the tests use Python 3

Which issue(s) this PR fixes:

Fixes #1413

Does this PR introduce a user-facing change?

The `python2` support will be removed in 18.0.0 beta release. All the tests will use `python3` versions.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes-client/python/blob/master/CHANGELOG.md#v1700-snapshot

Signed-off-by: Priyanka Saggu priyankasaggu11929@gmail.com

k8s-ci-robot · 2021-05-14T14:28:42Z

@Priyankasaggu11929: The label(s) kind/clean-up cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature
/kind clean-up

What this PR does / why we need it:

The PR makes changes to drop support for Python 2 from the next release (v18.0.0). The changes includes:

drop Python 2 from master branch

make sure all the tests use Python 3

drop Python 2 from v18 beta release.

Which issue(s) this PR fixes:

Fixes #1413

Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
https://github.com/kubernetes-client/python/blob/master/CHANGELOG.md#v1700-snapshot
Signed-off-by: Priyanka Saggu priyankasaggu11929@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Priyanka Saggu <priyankasaggu11929@gmail.com>

Priyankasaggu11929 · 2021-05-14T19:00:16Z

@yliaog @roycaihw

Need advice here: https://travis-ci.org/github/kubernetes-client/python/jobs/771168725

I'm trying to update the scripts/update-pycodestyle.sh test file to make it compatible with python3 versions. To begin testing, I'm starting with python version 3.9

From the .travis.yaml file

  - stage: test
    python: 3.9
    env: TOXENV=update-pycodestyle

The pycodestyle when ran with python v3.9 is throwing errors & suggesting changes in the python scripts (for ex - in case of above failing job, it is prompting for changes in examples/multiple_clusters.py python file)

Q 1: So, I want to confirm that the right way to update the scripts/update-pycodestyle.sh (& other tests) would be step by step correcting the example files until it goes all green for python v3.9? right?
- Correcting the example files made the job run successfully. So, I'm feeling yes, I need to keep correcting the example files wherever it breaks by applying suggested fixes.
Q 2: I would have to add the update-pycodestyle check for all the current set of python3 versions ( py3{5,6,7,8,9} )?
Q 3: What's the difference between py3{5,6,7,8,9} & py3{5,6,7,8,9}-functional?

Thank you!

- remove python2 from the .travis.yaml file - remove python2 from the tox.ini file - remove `-y` flag from isort command in update-pycodestle.sh script - fix sequence of module imports to fix faiing pycodestyle check in the following files: - examples/multiple_clusters.py - examples/pick_kube_config_context.py - examples/pod_config_list.py - testing coverage & codecov tests with python3 - testing `update-pycodestyle` for python v3.9 and arch ppc6le Signed-off-by: Priyanka Saggu <priyankasaggu11929@gmail.com>

Priyankasaggu11929 · 2021-05-17T04:22:29Z

@roycaihw , @yliaog

[Update]

So far, I have done the following to remove Python 2 support:

removed python2 from the .travis.yaml file
removed python2 from the tox.ini file
removed python2 from the .github/workflows/test.yaml file
removed -y flag from isort command in update-pycodestle.sh script (as it was throwing error for unknown flag -y while executing it with python3 versions)
fixed sequence of module imports in the following files, to fix the failing pycodestyle checks:
- examples/multiple_clusters.py
- examples/pick_kube_config_context.py
- examples/pod_config_list.py
tested coverage & codecov tests with python3 version (currently v3.9)
tested updated update-pycodestyle.sh for python3 version v3.9 and architecture type, ppc6le

With these much changes, the CI jobs are green so far.

yliaog

please remove '[WIP]'

yliaog · 2021-05-17T16:41:16Z

.travis.yml

    env: TOXENV=update-pycodestyle
-    arch: ppc64le
+    arch: ppc64le    


looks there are extra spaces at the end, please remove them

removed the spaces. Thanks!

yliaog · 2021-05-17T16:42:26Z

scripts/update-pycodestyle.sh

@@ -67,7 +67,7 @@ done

 echo "--- applying isort"
 for SOURCE in $SOURCES; do
-    isort -y $SOURCE
+    isort $SOURCE


it should have been called before with python3, not sure why there was no errors before

Just to confirm, there is no action required here, right?

Thank you!

no action, just wondering if you know why there was no error before

There were no previous test running update-pycodestyle.sh script with python3.x versions.

ok, that explains it.

yliaog · 2021-05-17T17:00:36Z

/lgtm
/approve

k8s-ci-robot · 2021-05-17T17:00:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Priyankasaggu11929, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [yliaog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Priyankasaggu11929 · 2021-05-17T17:03:42Z

Also, re-iterating over questions asked in this comment #1468 (comment) :

Q 2: Do I require to add the update-pycodestyle.sh check for all the current set of python3 versions ( py3{5,6,7,8,9} )?

Q 3: What's the difference between py3{5,6,7,8,9} & py3{5,6,7,8,9}-functional?

yliaog · 2021-05-17T17:53:11Z

sorry, missed your prior questions.
Q2: you only need to run one python3 version, say python 37, as all python3 versions share one common style guide

Q3: functional has e2e tests, the commands to show the difference is here:

python/tox.ini

Line 15 in 821618f

functional: {toxinidir}/scripts/kube-init.sh pytest -vvv -s []

Priyankasaggu11929 · 2021-05-17T18:15:06Z

Thank you @yliaog. That was really helpful clarification. :)

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2021

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 14, 2021

k8s-ci-robot requested review from roycaihw and yliaog May 14, 2021 14:28

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 14, 2021

Priyankasaggu11929 force-pushed the drop-python-2-support branch 3 times, most recently from db5f1fc to c49368b Compare May 14, 2021 15:20

drop python2 support from k8s-client/python

4431c4d

Signed-off-by: Priyanka Saggu <priyankasaggu11929@gmail.com>

Priyankasaggu11929 force-pushed the drop-python-2-support branch 2 times, most recently from 16986e3 to 4a2a030 Compare May 14, 2021 18:40

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2021

Priyankasaggu11929 force-pushed the drop-python-2-support branch 2 times, most recently from 7c1c0c3 to 81c65bf Compare May 14, 2021 19:19

Priyankasaggu11929 force-pushed the drop-python-2-support branch from 81c65bf to 6f09733 Compare May 14, 2021 19:28

Priyankasaggu11929 mentioned this pull request May 14, 2021

drop python2 support kubernetes-client/python-base#238

Merged

2 tasks

yliaog reviewed May 17, 2021

View reviewed changes

Priyankasaggu11929 changed the title ~~[WIP] drop python 2 support~~ drop python 2 support May 17, 2021

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2021

k8s-ci-robot assigned yliaog May 17, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 17, 2021

k8s-ci-robot merged commit 821618f into kubernetes-client:master May 17, 2021

jonasdlindner mentioned this pull request Jun 29, 2021

Python2 support dropped but installation works #1502

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drop python 2 support #1468

drop python 2 support #1468

Priyankasaggu11929 commented May 14, 2021 •

edited

k8s-ci-robot commented May 14, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Priyankasaggu11929 commented May 14, 2021 •

edited

Priyankasaggu11929 commented May 17, 2021 •

edited

yliaog left a comment

yliaog May 17, 2021

Priyankasaggu11929 May 17, 2021

yliaog May 17, 2021

Priyankasaggu11929 May 17, 2021

yliaog May 17, 2021

Priyankasaggu11929 May 17, 2021

yliaog May 17, 2021

yliaog commented May 17, 2021

k8s-ci-robot commented May 17, 2021

Priyankasaggu11929 commented May 17, 2021

yliaog commented May 17, 2021

Priyankasaggu11929 commented May 17, 2021

drop python 2 support #1468

drop python 2 support #1468

Conversation

Priyankasaggu11929 commented May 14, 2021 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented May 14, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Priyankasaggu11929 commented May 14, 2021 • edited

Priyankasaggu11929 commented May 17, 2021 • edited

yliaog left a comment

Choose a reason for hiding this comment

yliaog May 17, 2021

Choose a reason for hiding this comment

Priyankasaggu11929 May 17, 2021

Choose a reason for hiding this comment

yliaog May 17, 2021

Choose a reason for hiding this comment

Priyankasaggu11929 May 17, 2021

Choose a reason for hiding this comment

yliaog May 17, 2021

Choose a reason for hiding this comment

Priyankasaggu11929 May 17, 2021

Choose a reason for hiding this comment

yliaog May 17, 2021

Choose a reason for hiding this comment

yliaog commented May 17, 2021

k8s-ci-robot commented May 17, 2021

Priyankasaggu11929 commented May 17, 2021

yliaog commented May 17, 2021

Priyankasaggu11929 commented May 17, 2021

Priyankasaggu11929 commented May 14, 2021 •

edited

Priyankasaggu11929 commented May 14, 2021 •

edited

Priyankasaggu11929 commented May 17, 2021 •

edited