New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for remote cluster without kube client on server #446

Merged
merged 4 commits into from Oct 31, 2018

Conversation

Projects
None yet
7 participants
@charly37
Copy link
Contributor

charly37 commented Jan 27, 2018

Propose a new example to demonstrate communication from a server that do not have kube client installed. It show how to create a config object and also setup a barer token to authenticate.

The idea come from a recent issue tracker #430

@charly37 charly37 force-pushed the charly37:master branch from 66d155e to 317aeee Jan 27, 2018

configuration.api_key = {"authorization": "Bearer " + aToken}

# Use our configuration
client.Configuration.set_default(configuration)

This comment has been minimized.

@mbohlool

mbohlool Feb 26, 2018

Member

I suggest you an ApiClient and pass it to client.CoreV1Api instead of changing the default.

@mbohlool

This comment has been minimized.

Copy link
Member

mbohlool commented Feb 26, 2018

Thanks for the contribution. It looks good except one comment.

@charly37 charly37 force-pushed the charly37:master branch from 2d8593f to 8b2b3cd Jul 26, 2018

@charly37

This comment has been minimized.

Copy link
Contributor

charly37 commented Jul 26, 2018

Sorry It took me so long to review. I updated and tested (with a cluster on GKE) following the feedback.

@hellt

This comment has been minimized.

Copy link

hellt commented Oct 4, 2018

thanks for showing this in your blog, I think basic auth should be included as you explained gere https://djynet.net/?p=918

# See the License for the specific language governing permissions and
# limitations under the License.

# This example demonstrate communication with a remove Kube cluster from a

This comment has been minimized.

@MrAmbiG

MrAmbiG Oct 26, 2018

remove --> remote

This comment has been minimized.

@charly37

charly37 Oct 27, 2018

Contributor

Thx !

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 27, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@charly37 charly37 force-pushed the charly37:master branch from 9695917 to 0bbb567 Oct 27, 2018

@@ -0,0 +1,58 @@
# Copyright 2016 The Kubernetes Authors.

This comment has been minimized.

@micw523

micw523 Oct 30, 2018

Member

May look trivial, but 2016->2018

This comment has been minimized.

@charly37

charly37 Oct 30, 2018

Contributor

Fix. Thx. Now we just need to hope it is merge before 2019 ;)

@charly37 charly37 force-pushed the charly37:master branch from 0bbb567 to 67ae262 Oct 30, 2018

@micw523

This comment has been minimized.

Copy link
Member

micw523 commented Oct 31, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 31, 2018

@micw523: changing LGTM is restricted to assignees, and only kubernetes-client/python repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roycaihw

This comment has been minimized.

Copy link
Member

roycaihw commented Oct 31, 2018

/lgtm
/approve

Thanks for the PR and reminding ;)

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 31, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charly37, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1efbab9 into kubernetes-client:master Oct 31, 2018

3 checks passed

cla/linuxfoundation charly37 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
tide In merge pool.
Details

@micw523 micw523 referenced this pull request Nov 9, 2018

Closed

REQUEST: New membership for micw523 #232

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment