Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bypass chmod if mounting point permissions are correct #340

Merged
merged 1 commit into from May 13, 2022
Merged

fix: bypass chmod if mounting point permissions are correct #340

merged 1 commit into from May 13, 2022

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: bypass chmod if mounting point permissions are correct

Which issue(s) this PR fixes:

Fixes #337

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: bypass chmod if mounting point permissions are correct

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 12, 2022
@coveralls
Copy link

coveralls commented May 12, 2022 •
edited

Pull Request Test Coverage Report for Build 2313650245

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 76.217%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/nfs/nodeserver.go 9 11 81.82%
Totals Coverage Status
Change from base Build 2312011081: 0.02%
Covered Lines: 548
Relevant Lines: 719
💛 - Coveralls

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit 09c8362 into kubernetes-csi:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiawei0227 Jiawei0227 Awaiting requested review from Jiawei0227

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bypass chmod if mounting point permissions are correct
3 participants
@andyzhangx @k8s-ci-robot @coveralls