Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use force unmount to fix unmount NFS volume stuck issue #394

Merged
merged 4 commits into from Jan 15, 2023
Merged

fix: use force unmount to fix unmount NFS volume stuck issue #394

merged 4 commits into from Jan 15, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Dec 24, 2022 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: use force unmount to fix unmount NFS volume stuck issue, port fix from kubernetes/kubernetes#96844

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: use force unmount to fix unmount NFS volume stuck issue

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 24, 2022
@coveralls
Copy link

coveralls commented Dec 24, 2022 •
edited

Pull Request Test Coverage Report for Build 3865075936

  • 13 of 15 (86.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 77.33%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/nfs/nodeserver.go 7 9 77.78%
Totals Coverage Status
Change from base Build 3829316070: 0.1%
Covered Lines: 614
Relevant Lines: 794
💛 - Coveralls

@andyzhangx andyzhangx changed the title feat: use force unmount to fix unmount failure issue fix: use force unmount to fix unmount failure issue Dec 24, 2022
@andyzhangx
Copy link
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 24, 2022
@andyzhangx andyzhangx changed the title fix: use force unmount to fix unmount failure issue [WIP]fix: use force unmount to fix unmount failure issue Dec 24, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2022
@andyzhangx andyzhangx changed the title [WIP]fix: use force unmount to fix unmount failure issue fix: use force unmount to fix unmount NFS volume stuck issue Dec 29, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 29, 2022
@andyzhangx andyzhangx changed the title fix: use force unmount to fix unmount NFS volume stuck issue [WIP]fix: use force unmount to fix unmount NFS volume stuck issue Dec 29, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 29, 2022
@andyzhangx andyzhangx changed the title [WIP]fix: use force unmount to fix unmount NFS volume stuck issue fix: use force unmount to fix unmount NFS volume stuck issue Jan 8, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2023
@andyzhangx andyzhangx merged commit f084312 into kubernetes-csi:master Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@Jiawei0227 Jiawei0227 Awaiting requested review from Jiawei0227

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andyzhangx @k8s-ci-robot @coveralls