Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding the skeleton for versioned APIs, both servers and clients #7
What type of PR is this?
What this PR does / why we need it:
This patch proposes a generic framework to be able to easily define, maintain
The whole idea is documented in
Please note that all
With integration tests with a dummy API group, across 3 versions, with breaking
Also some unit tests where relevant.
Special notes for your reviewer:
Please make sure to read
Does this PR introduce a user-facing change?:
@ddebroy: GitHub didn't allow me to assign the following users: peterhornyack.
Note that only kubernetes-csi members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
This patch proposes a generic framework to be able to easily define, maintain and extend versioned API groups going forward. The whole idea is documented in `api/README.md`; reviewers should read that file before reviewing the rest of the PR. Please note that all `*_generated.go` files in this PR are _meant_ to be auto-generated by a tool based on gengo, but that tool will only be written after this patch's approach is accepted and this PR merged; in particular `*_generated.go` files in this PR should be reviewed. With integration tests with a dummy API group, across 3 versions, with breaking changes in conversions from one version to the next. Also some unit tests where relevant. Signed-off-by: Jean Rouge <email@example.com>
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing