Add wrapper script for sidecar release #210

sunnylovestiramisu · 2022-11-29T05:11:12Z

A wrapper script to generate sidecar release prs from go-get-kubernetes.sh: #7 (comment)

Change the repo that you need to generate the pr.

Sample command:

./go-modules-update.sh -v 1.26.0-rc.0 -u sunnylovestiramisu

NONE

k8s-ci-robot · 2022-11-29T05:11:20Z

Welcome @sunnylovestiramisu!

It looks like this is your first PR to kubernetes-csi/csi-release-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-release-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-11-29T05:11:21Z

Hi @sunnylovestiramisu. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

msau42 · 2022-11-29T19:05:47Z

/ok-to-test

go-modules-update.sh

msau42 · 2022-11-29T19:32:51Z

go-modules-update.sh

+                    die "git subtree pull --squash failed, cannot reover."
+                fi
+            fi
+            while ! ./release-tools/go-get-kubernetes.sh -p 1.26.0-rc.0


Can you define a retry limit? Otherwise this can loop forever?

go-modules-update.sh

msau42 · 2022-11-29T19:35:11Z

go-modules-update.sh

+        for i in $branches; do
+            git checkout -B module-update-$i origin/$i || die "$repo:$i checkout"
+            rm -rf .git/MERGE*
+            if ! git subtree pull --squash --prefix=release-tools https://github.com/kubernetes-csi/csi-release-tools.git master; then


This script is also updating csi-release-tools. Do we want to include that in the script or have separate scripts?

What do you mean separate? Do you mean everything in go-get-kubernetes?

should we have 2 different scripts? One for updating csi-release-tools, and another for updating kubernetes dependencies?

go-modules-update.sh

msau42 · 2022-11-29T19:39:01Z

go-modules-update.sh

+            git commit -m "Update dependency go modules for k8s v1.26.0-rc.0" || die "commit update modules"
+            git remote set-url origin https://github.com/sunnylovestiramisu/$repo.git || die "git remote set-url failed"
+            make test || die "$repo:$i make test"
+            git push origin module-update-$i --force || die "origin:module-update-$i push failed - probably there is already an unmerged branch and pending PR"


Would this fail if you already have a PR, or would it update the PR?

go-modules-update.sh

msau42 · 2023-04-05T20:14:27Z

@sunnylovestiramisu do you plan to continue with this?

sunnylovestiramisu · 2023-04-05T20:28:51Z

@sunnylovestiramisu do you plan to continue with this?

I am using it personally, but did not get the time to make it pass the presubmits yet.

k8s-triage-robot · 2023-07-04T21:23:35Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

sunnylovestiramisu · 2023-08-15T16:07:51Z

/assign @msau42

go-modules-update.sh

msau42 · 2023-12-12T18:40:07Z

go-modules-update.sh

+# 5. Run script from the kubernetes-csi directory
+#
+# Caveats:
+# - This script doesn't handle interface incompatibility of updates.


If someone runs into it, are there steps to follow to resolve the conflicts and rerun the script?

msau42 · 2023-12-12T18:41:39Z

Can you also update https://github.com/kubernetes-csi/csi-release-tools/blob/master/SIDECAR_RELEASE_PROCESS.md

msau42 · 2023-12-12T19:05:28Z

/lgtm
/approve

k8s-ci-robot · 2023-12-12T19:05:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 29, 2022

k8s-ci-robot requested review from Jiawei0227 and jingxu97 November 29, 2022 05:11

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 29, 2022

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 29, 2022

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2022

msau42 reviewed Nov 29, 2022

View reviewed changes

sunnylovestiramisu force-pushed the sidecar branch 3 times, most recently from cbff685 to 4d29bc3 Compare November 30, 2022 22:10

sunnylovestiramisu force-pushed the sidecar branch from 4d29bc3 to b2d3d4e Compare December 21, 2022 17:36

sunnylovestiramisu force-pushed the sidecar branch from b2d3d4e to 7cf2b4a Compare March 21, 2023 16:40

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2023

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 8, 2023

sunnylovestiramisu force-pushed the sidecar branch 7 times, most recently from 093a3ed to d04da1f Compare August 15, 2023 00:46

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2023

k8s-ci-robot assigned msau42 Aug 15, 2023

Sneha-at reviewed Sep 6, 2023

View reviewed changes

go-modules-update.sh Outdated Show resolved Hide resolved

go-modules-update.sh Outdated Show resolved Hide resolved

msau42 reviewed Oct 19, 2023

View reviewed changes

go-modules-update.sh Outdated Show resolved Hide resolved

sunnylovestiramisu force-pushed the sidecar branch 11 times, most recently from 5118c9d to fc3d657 Compare December 1, 2023 01:18

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2023

Add wrapper script for sidecar release

5deaf66

sunnylovestiramisu force-pushed the sidecar branch from fc3d657 to 5deaf66 Compare December 1, 2023 01:20

msau42 reviewed Dec 12, 2023

View reviewed changes

sunnylovestiramisu force-pushed the sidecar branch from 507d9a5 to 79f34bd Compare December 12, 2023 18:56

Use set -x instead of die

011033d

sunnylovestiramisu force-pushed the sidecar branch from 79f34bd to 011033d Compare December 12, 2023 18:58

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023

k8s-ci-robot merged commit a17f536 into kubernetes-csi:master Dec 12, 2023
4 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add wrapper script for sidecar release #210

Add wrapper script for sidecar release #210

sunnylovestiramisu commented Nov 29, 2022 •

edited

k8s-ci-robot commented Nov 29, 2022

k8s-ci-robot commented Nov 29, 2022

msau42 commented Nov 29, 2022

msau42 Nov 29, 2022

msau42 Nov 29, 2022

sunnylovestiramisu Nov 29, 2022

msau42 Nov 30, 2022

msau42 Nov 29, 2022

msau42 commented Apr 5, 2023

sunnylovestiramisu commented Apr 5, 2023

k8s-triage-robot commented Jul 4, 2023

sunnylovestiramisu commented Aug 15, 2023

msau42 Dec 12, 2023

msau42 commented Dec 12, 2023

msau42 commented Dec 12, 2023

k8s-ci-robot commented Dec 12, 2023

Add wrapper script for sidecar release #210

Add wrapper script for sidecar release #210

Conversation

sunnylovestiramisu commented Nov 29, 2022 • edited

k8s-ci-robot commented Nov 29, 2022

k8s-ci-robot commented Nov 29, 2022

msau42 commented Nov 29, 2022

msau42 Nov 29, 2022

Choose a reason for hiding this comment

msau42 Nov 29, 2022

Choose a reason for hiding this comment

sunnylovestiramisu Nov 29, 2022

Choose a reason for hiding this comment

msau42 Nov 30, 2022

Choose a reason for hiding this comment

msau42 Nov 29, 2022

Choose a reason for hiding this comment

msau42 commented Apr 5, 2023

sunnylovestiramisu commented Apr 5, 2023

k8s-triage-robot commented Jul 4, 2023

sunnylovestiramisu commented Aug 15, 2023

msau42 Dec 12, 2023

Choose a reason for hiding this comment

msau42 commented Dec 12, 2023

msau42 commented Dec 12, 2023

k8s-ci-robot commented Dec 12, 2023

sunnylovestiramisu commented Nov 29, 2022 •

edited