Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.2: update release-tools #378

Closed

Conversation

@pohly
Copy link
Contributor

pohly commented Nov 4, 2019

Commit summary:
8067845 travis.yml: also use vendor directory
23df4ae prow.sh: use vendor directory if available
c8a1c4a better handling of Go version
5e773d2 update CI to use Go 1.13.3
e0fde8c Add new variables for 1.16 and remove 1.13

NONE
msau42 and others added 9 commits Oct 31, 2019
Add new variables for 1.16 and remove 1.13
This is the latest release. Updating is useful to ensure that we have
all of the latest fixes and enhancements.
Some operations are sensitive to the version of Go that is used. In
the past, formatting of source differed depending on the
version. Right now it is the content of the vendor directory which
changes when switch back and forth between 1.12 and 1.13.

We don't want to impose a certain workflow on developers, like forcing
all invocations of Go to run inside a container. If developers want
that, they can set up their development environment accordingly.

But we should warn about this aspect to raise awareness. "make"
invocations which involve Go now compare against the projects Go
version (specified in travis.yml) once at the beginning. This is only
a warning because we don't know which future version will be
compatible with the project.

Vendor directory handling gets updated, too: verification is now a
separate script (became too complex for make) and there is a
corresponding "update-vendor.sh". In contrast to verification,
updating vendor is not integrated into make and thus itself invokes
the go version check.
Go version 1.13, helper scripts
This avoids dependencies on the Go module cache or the upstream code
hosting.
prow.sh: use vendor directory if available
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 4, 2019

@pohly: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-provisioner-1-15-on-kubernetes-1-15 e80dd0f link /test pull-kubernetes-csi-external-provisioner-1-15-on-kubernetes-1-15
pull-kubernetes-csi-external-provisioner-1-14-on-kubernetes-1-14 e80dd0f link /test pull-kubernetes-csi-external-provisioner-1-14-on-kubernetes-1-14
pull-kubernetes-csi-external-provisioner-unit e80dd0f link /test pull-kubernetes-csi-external-provisioner-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pohly pohly closed this Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.