Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README file #59

Merged
merged 1 commit into from Oct 14, 2019
Merged

Conversation

@gnufied
Copy link
Contributor

gnufied commented Oct 10, 2019

update readme file to be consistent with other CSI sidecars.

/assign @msau42

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 10, 2019

@gnufied: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

msau42 left a comment

/approve

Just a tiny nit

README.md Outdated

# Build
The CSI `external-resizer` is a sidecar container that watches the Kubernetes API server for `PersistentVolumeClaim` object edits and

This comment has been minimized.

Copy link
@msau42

msau42 Oct 11, 2019

Collaborator

"object edits" => "updates"

This comment has been minimized.

Copy link
@gnufied

gnufied Oct 14, 2019

Author Contributor

fixed

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msau42

This comment has been minimized.

Copy link
Collaborator

msau42 commented Oct 11, 2019

/release-note-none

@gnufied gnufied force-pushed the gnufied:refactor-readme branch from 9a86f29 to 11067ce Oct 14, 2019
@msau42

This comment has been minimized.

Copy link
Collaborator

msau42 commented Oct 14, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 150071d into kubernetes-csi:master Oct 14, 2019
5 of 6 checks passed
5 of 6 checks passed
tide Not mergeable.
Details
cla/linuxfoundation gnufied authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pull-kubernetes-csi-external-resizer-1-14-on-kubernetes-1-14 Job succeeded.
Details
pull-kubernetes-csi-external-resizer-1-15-on-kubernetes-1-15 Job succeeded.
Details
pull-kubernetes-csi-external-resizer-unit Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.