release-2.1: Update release tools for go build fix #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update patch release notes generation command
The approach taken here extends the existing support for cross-compiling binaries on the build host and specifying the Go compiler: Go is installed if needed (as in Prow testing), binaries are build on the host, then one image is created for each platform, and finally those are combined into a single multi-architecture image.
cloud build: initial set of shared files
"make push-multiarch" matched both push-multiarch and push-%. This seems to be none-deterministic and in at least one repo (external-provisioner), make picked the wildcard rule which then failed because there is no "multiarch" command. This ambiguity gets resolved by instantiating the wildcard rules only for existing commands. The advantage also is that "make push-no-such-command" will fail with an obvious "No rule to make target 'push-no-such-command'" instead of attempting to build the command.
It's not a real file and thus should better be marked as phony.
Most repos inherit the default BUILD_PLATFORMS, which includes Windows, but don't have the necessary Dockerfile.Windows yet. To simplify the rollout of multiarch image builds, Windows binary building continues to be tested (i.e. BUILD_PLATFORMS remains unchanged), but push-multiarch skips Windows if the Dockerfile.Windows is missing.
multiarch windows fix
If the Dockerfile needs to run some command, that step fails unless
QEMU is set up properly first:
failed to solve: rpc error: code = Unknown desc = failed to load
LLB: runtime execution on platform linux/ppc64le not supported
cloud build: initialize support for running commands in Dockerfile
As discussed in kubernetes/k8s.io#943, we want to consolidate under k8s-staging-sig-storage.
cloud build: k8s-staging-sig-storage
prow.sh: enable building arm64 image
Signed-off-by: Animesh Kumar <animuz111@gmail.com>
filter-junit: Fix golint error
Signed-off-by: Animesh Kumar <animuz111@gmail.com>
filter-junit: Fix gofmt error
cloud build: bump timeout in Prow job
Add steps on promoting release images
Go 1.15 was released and is the major version that Kubernetes 1.19.0 is going to use. There are probably bugs in the older 1.13.3 that were fixed, so we should update.
switch to Go 1.15
Kubernetes 1.19.0 uses Go 1.15, but refers to it as 1.15.0. This broke both the check whether we need to install 1.15 (because "go version" reports 1.15, which didn't match 1.15.0) and then downloading the release archive (because the URL also only uses 1.15).
It used to be necessary to override from where the E2E suite came on a case-by-case basis (initially, testing was using a more recent suite against an older Kubernetes). This should never become necessary again and the lack of a specific entry for 1.18 already had the unintended effect that Kubernetes 1.18 was tested with the suite from master, so overall it is better to always use the E2E suite which matches Kubernetes.
Kubernetes 1.19 fixes
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
|
This fixed the build error mentioned in #385, but for some reason the jobs are failing to pull a few images. |
|
/retest |
ggriffiths
force-pushed
the
r21_fix_build_install_go115
branch
from
cb596cc to
3a54364
Compare
k8s-ci-robot
added
needs-rebase
…build_install_go115
ggriffiths
force-pushed
the
r21_fix_build_install_go115
branch
from
3a54364 to
b7bba3e
Compare
k8s-ci-robot
added
size/L
|
I think I found the problem. Latest release tools uses the new staging registry: but, some of the images below are not there:
I'm updating the release-tools here to a few commits before that to unblock PRs to external-snapshotter:release-2.1. |
|
I think what needs to happen is to release a new 1.4.1 of the hostpath driver with updated sidecars, and then we update gen-jobs in test-infra to use 1.4.1: https://github.com/kubernetes/test-infra/pull/19280/files#diff-96340ecad23cb8abd9aa581e9b2864ecR47. I can work on that next week. In the meantime, updating release tools to before this commit is fine. |
|
That sounds good! I can help with those updates as well. |
|
/test pull-kubernetes-csi-external-snapshotter-1-19-on-kubernetes-1-19 |
ggriffiths
changed the title
|
This looks good to me. @ggriffiths @msau42 anything else needs to be addressed in this PR before merging? |
|
/lgtm We'll address the remaining items as a followup |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggriffiths, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates the release tools to latest upstream
Which issue(s) this PR fixes:
Fixes #385
Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?: