Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow update master #50

Merged
merged 11 commits into from Sep 9, 2019
Merged

Conversation

@msau42
Copy link
Collaborator

msau42 commented Sep 7, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Picks up the following changes:

  • Update kind to v0.5.0
  • Enables Windows builds
  • Enables dep testing in prow
  • Creates kind cluster with 2 nodes to help test topology

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
msau42 and others added 8 commits Aug 21, 2019
Update kind to v0.5.0
Signed-off-by: Deep Debroy <ddebroy@docker.com>
Add rule for building Windows binaries
"make test-vendor" depends on dep if the current project uses
dep. Without it, the vendor directory checking was skipped under Prow.
prow.sh: install dep if needed
…h driver

Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
Create 2-node kind cluster since topology support is added to hostpath
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msau42

This comment has been minimized.

Copy link
Collaborator Author

msau42 commented Sep 7, 2019

/assign @pohly

msau42 and others added 3 commits Sep 7, 2019
build windows binaries with .exe suffix
@msau42 msau42 force-pushed the msau42:prow-update-master branch from f7a474a to 183a86e Sep 7, 2019
@pohly

This comment has been minimized.

Copy link
Contributor

pohly commented Sep 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5912d2b into kubernetes-csi:master Sep 9, 2019
7 checks passed
7 checks passed
cla/linuxfoundation msau42 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pull-kubernetes-csi-node-driver-registrar-1-13-on-kubernetes-1-13 Job succeeded.
Details
pull-kubernetes-csi-node-driver-registrar-1-14-on-kubernetes-1-14 Job succeeded.
Details
pull-kubernetes-csi-node-driver-registrar-1-15-on-kubernetes-1-15 Job succeeded.
Details
pull-kubernetes-csi-node-driver-registrar-unit Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.