This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
assets: use MkdirAll to not error on existing dir #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
colemickens
approved these changes
Feb 12, 2018
Fixes kubernetes-retired#884 * make sure assets directory is empty
rphillips
force-pushed
the
fixes/assets_mkdirall
branch
from
315c67d
to
bc38dc6
Compare
k8s-ci-robot
added
size/S
|
updated the PR and e2e failed on an AWS error |
xiang90
reviewed
Feb 12, 2018
pkg/asset/asset.go
Outdated
| return err | ||
| } | ||
| if len(files) > 0 { | ||
| return errors.New("Asset directory must be empty.") |
There was a problem hiding this comment.
Asset -> asset. Error strings should not be capitalized: https://github.com/golang/go/wiki/CodeReviewComments#error-strings
|
coreosbot run e2e |
|
@xiang90 could you review please |
diegs
approved these changes
Feb 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.Mkdir will error on an existing directory. Allows for existing mount points for assets.
Fixes #884