New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.10] conmon: on a flush error discard the iov buffer #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
k8s-ci-robot
added
cncf-cla: yes
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Jun 12, 2018
/test all |
/test e2e_rhel |
@mrunalp is this critical for an immediate new release? |
@runcom This isn't urgent to cut a release. Just backporting so we don't forget for next release :) |
/test e2e_rhel |
1 similar comment
/test e2e_rhel |
runcom
approved these changes
Jun 13, 2018
LGTM |
1 similar comment
LGTM |
/test e2e_rhel |
3 similar comments
/test e2e_rhel |
/test e2e_rhel |
/test e2e_rhel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com
Backport to 1.10
@runcom @giuseppe