Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.10] conmon: on a flush error discard the iov buffer #1611

Merged
merged 1 commit into from Jun 14, 2018

Conversation

mrunalp
Copy link
Member

@mrunalp mrunalp commented Jun 12, 2018

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

Backport to 1.10

@runcom @giuseppe

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@mrunalp mrunalp requested a review from runcom as a code owner June 12, 2018 18:40
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 12, 2018
@mrunalp
Copy link
Member Author

mrunalp commented Jun 12, 2018

/test all

@runcom
Copy link
Member

runcom commented Jun 12, 2018

/test e2e_rhel

@runcom
Copy link
Member

runcom commented Jun 12, 2018

@mrunalp is this critical for an immediate new release?

@mrunalp
Copy link
Member Author

mrunalp commented Jun 13, 2018

@runcom This isn't urgent to cut a release. Just backporting so we don't forget for next release :)

@mrunalp
Copy link
Member Author

mrunalp commented Jun 13, 2018

/test e2e_rhel

1 similar comment
@runcom
Copy link
Member

runcom commented Jun 13, 2018

/test e2e_rhel

@rhatdan
Copy link
Contributor

rhatdan commented Jun 13, 2018

LGTM

1 similar comment
@TomSweeneyRedHat
Copy link
Contributor

LGTM

@runcom
Copy link
Member

runcom commented Jun 13, 2018

/test e2e_rhel

3 similar comments
@runcom
Copy link
Member

runcom commented Jun 13, 2018

/test e2e_rhel

@runcom
Copy link
Member

runcom commented Jun 13, 2018

/test e2e_rhel

@mrunalp
Copy link
Member Author

mrunalp commented Jun 13, 2018

/test e2e_rhel

@runcom runcom merged commit 3a3f346 into cri-o:release-1.10 Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants