New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct semantic version checks #1374

Merged
merged 3 commits into from Jun 24, 2018

Conversation

Projects
None yet
5 participants
@kevtaylor
Contributor

kevtaylor commented Jun 20, 2018

Fixes #1373

@kevtaylor kevtaylor changed the title from Add a version checker library to Correct semantic version checks Jun 20, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 20, 2018

Codecov Report

Merging #1374 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
- Coverage   37.31%   37.24%   -0.07%     
==========================================
  Files          74       74              
  Lines        4478     4486       +8     
==========================================
  Hits         1671     1671              
- Misses       2576     2584       +8     
  Partials      231      231
Impacted Files Coverage Δ
filereader/texttemplate/texttemplate.go 5.79% <0%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f8ac50...1b885a4. Read the comment docs.

codecov-io commented Jun 20, 2018

Codecov Report

Merging #1374 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
- Coverage   37.31%   37.24%   -0.07%     
==========================================
  Files          74       74              
  Lines        4478     4486       +8     
==========================================
  Hits         1671     1671              
- Misses       2576     2584       +8     
  Partials      231      231
Impacted Files Coverage Δ
filereader/texttemplate/texttemplate.go 5.79% <0%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f8ac50...1b885a4. Read the comment docs.

@c-knowles

This comment has been minimized.

Show comment
Hide comment
@c-knowles

c-knowles Jun 21, 2018

Collaborator

@kevtaylor there’s already the masterminds “semver” in use in the code checking for the reconciler, could we reuse the same to ensure dependencies are minimised?

Collaborator

c-knowles commented Jun 21, 2018

@kevtaylor there’s already the masterminds “semver” in use in the code checking for the reconciler, could we reuse the same to ensure dependencies are minimised?

@kevtaylor

This comment has been minimized.

Show comment
Hide comment
@kevtaylor

kevtaylor Jun 21, 2018

Contributor

@c-knowles I'll take a look. I didn't appreciate something was already in place.

Contributor

kevtaylor commented Jun 21, 2018

@c-knowles I'll take a look. I didn't appreciate something was already in place.

@k8s-ci-robot k8s-ci-robot added size/M and removed size/XXL labels Jun 21, 2018

@kevtaylor

This comment has been minimized.

Show comment
Hide comment
@kevtaylor

kevtaylor Jun 21, 2018

Contributor

@c-knowles @mumoshu Used semver instead

Contributor

kevtaylor commented Jun 21, 2018

@c-knowles @mumoshu Used semver instead

@c-knowles

This comment has been minimized.

Show comment
Hide comment
@c-knowles

c-knowles Jun 22, 2018

Collaborator

/lgtm

Collaborator

c-knowles commented Jun 22, 2018

/lgtm

@mumoshu

This comment has been minimized.

Show comment
Hide comment
@mumoshu

mumoshu Jun 22, 2018

Collaborator

@kevtaylor Thanks for the contribution! Can you also revert Gopkg.toml and Gopkg.lock? My understanding was that you don't need extra dependencies for this fix.

Collaborator

mumoshu commented Jun 22, 2018

@kevtaylor Thanks for the contribution! Can you also revert Gopkg.toml and Gopkg.lock? My understanding was that you don't need extra dependencies for this fix.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Jun 22, 2018

New changes are detected. LGTM label has been removed.

k8s-ci-robot commented Jun 22, 2018

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/S and removed lgtm size/M labels Jun 22, 2018

@kevtaylor

This comment has been minimized.

Show comment
Hide comment
@kevtaylor

kevtaylor Jun 22, 2018

Contributor

@mumoshu Apologies yes indeed. Submitted with reverted files

Contributor

kevtaylor commented Jun 22, 2018

@mumoshu Apologies yes indeed. Submitted with reverted files

@kevtaylor

This comment has been minimized.

Show comment
Hide comment
@kevtaylor

kevtaylor Jun 22, 2018

Contributor

/retest

Contributor

kevtaylor commented Jun 22, 2018

/retest

@kevtaylor

This comment has been minimized.

Show comment
Hide comment
@kevtaylor

kevtaylor Jun 22, 2018

Contributor

@mumoshu Seems like something occurred in the e2e tests? How do we force a retest?

UPDATE: Looks like something got stuck/timed out - forced an empty commit and the e2e worked 2nd time

Contributor

kevtaylor commented Jun 22, 2018

@mumoshu Seems like something occurred in the e2e tests? How do we force a retest?

UPDATE: Looks like something got stuck/timed out - forced an empty commit and the e2e worked 2nd time

@mumoshu

LGTM. Thanks as always for your contribution 🎉

@mumoshu mumoshu merged commit bde0133 into kubernetes-incubator:master Jun 24, 2018

2 checks passed

cla/linuxfoundation kevtaylor authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mumoshu mumoshu added this to the v0.11.0 milestone Jun 24, 2018

davidmccormick pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Jul 18, 2018

Correct semantic version checks (kubernetes-incubator#1374)
Fixes kubernetes-incubator#1373
Conflicts:
	filereader/texttemplate/texttemplate.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment