Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang version to v1.13.5 #1820

Merged
merged 1 commit into from Jan 6, 2020

Conversation

@chenrui333
Copy link
Contributor

chenrui333 commented Jan 4, 2020

Bump travis build config to use latest golang.

We have already shipped this in Homebrew v0.14.3 (Homebrew/homebrew-core#47394)

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 4, 2020

Welcome @chenrui333!

It looks like this is your first PR to kubernetes-incubator/kube-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/kube-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS label Jan 4, 2020
@k8s-ci-robot k8s-ci-robot requested review from mumoshu and redbaron Jan 4, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 4, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mumoshu
You can assign the PR to them by writing /assign @mumoshu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

chenrui333 commented Jan 5, 2020

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 5, 2020

Codecov Report

Merging #1820 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1820   +/-   ##
======================================
  Coverage    24.6%   24.6%           
======================================
  Files          98      98           
  Lines        5069    5069           
======================================
  Hits         1247    1247           
  Misses       3682    3682           
  Partials      140     140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e197df...563bd38. Read the comment docs.

@davidmccormick

This comment has been minimized.

Copy link
Collaborator

davidmccormick commented Jan 6, 2020

Many thanks for this contribution! 🙏

@davidmccormick davidmccormick merged commit f3e7be4 into kubernetes-incubator:master Jan 6, 2020
2 of 3 checks passed
2 of 3 checks passed
tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation chenrui333 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.