New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show FQDN first in /etc/hosts (closes: #3521) #3522

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@anarcat
Contributor

anarcat commented Oct 12, 2018

The hosts(5) manpage clearly states that the first entry is the
"canonical name", or FQDN (Fully-Qualified Domain Name):

IP_address canonical_hostname [aliases...]

By using the alias as a first entry, hostname -f does not return the
correct domain which breaks all sorts of unrelated functionality (it
has impact over email server configuration, for example).

show FQDN first in /etc/hosts (closes: #3521)
The hosts(5) manpage clearly states that the first entry is the
"canonical name", or FQDN (Fully-Qualified Domain Name):

    IP_address canonical_hostname [aliases...]

By using the alias as a first entry, `hostname -f` does not return the
correct domain which breaks all sorts of unrelated functionality (it
has impact over email server configuration, for example).
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 12, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anarcat

This comment has been minimized.

Contributor

anarcat commented Oct 12, 2018

I probably will get hit over the head on this, but I haven't been able to test this locally - I'm hoping the CI will do that work for me considering how small this change is. :) i'm also fighting with email/greylisting/whoknowswhat to clear that annoying CLA requirement.. sorry for the trouble.

@anarcat

This comment has been minimized.

Contributor

anarcat commented Oct 12, 2018

against my better judgment and with heaps of patience, i signed the CLA.

@anarcat

This comment has been minimized.

Contributor

anarcat commented Oct 12, 2018

no idea what else i'm supposed to do here. i'm lost in a maze of CI and bureaucracy. help!

@Atoms

This comment has been minimized.

Collaborator

Atoms commented Oct 16, 2018

ci check this

@Atoms

This comment has been minimized.

Collaborator

Atoms commented Oct 16, 2018

/lgtm

@Atoms

This comment has been minimized.

Collaborator

Atoms commented Oct 16, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 16, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Atoms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c33e08c into kubernetes-incubator:master Oct 16, 2018

2 of 3 checks passed

tide Not mergeable.
Details
cla/linuxfoundation anarcat authorized
Details
kubespray-ci/pipeline Pipeline Succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment