Separate kube-apiserver-availability.rules into own group (w/ 3min interval) #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…val) Additionally I also had to fix the scope=~"resource|" for Kubernetes 1.18+, as the scope="resource" doesn't seem to exist anymore.
|
nice 👍 lgtm |
This was referenced Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recording Rules
First, I've added a more explicit
code_verb:apiserver_request_total:increase30drecording rule for which we now iterate overfor code in ['2..', '3..', '4..', '5..']andfor verb in ['LIST', 'GET', 'POST', 'PUT', 'PATCH', 'DELETE']evaluating these individual combinations on their own. This will add 24 more recording rules, but nicely split those up :)The 3min evaluation interval has the nice side effect of really saving some CPU again (as reported by others resulting in higher usage, hi @smoke)
Additionally, I also had to fix the
scope=~"resource|"for Kubernetes 1.18+, as thescope="resource"doesn't seem to exist anymore.Dashboard
The dashboard need some cleaning up and I put a bit time into it:
The biggest change here would be that both Read and Write SLI - Requests panels now show the requests
by (code). I've deleted a few older and now duplicate panels too.Each panel now has a description explaining a bit about what they show.
/cc @brancz @povilasv @jamie-34254 @smoke @anyname2 @ekeih @billimek
Closes #394 prometheus-operator/kube-prometheus#503 helm/charts#22003