fix: KubePersistentVolumeFillingUp - false alert fires for PVCs with volumeMode as block #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
arajkumar
force-pushed
the
patch-KubePersistentVolumeFillingUp-for-block-vol
branch
from
0ad6a54
to
85e8c51
Compare
|
lgtm. It would be good to add a unit test for the |
arajkumar
force-pushed
the
patch-KubePersistentVolumeFillingUp-for-block-vol
branch
from
85e8c51
to
c1dd159
Compare
|
Thanks @simonpasquier, Added tests with |
arajkumar
force-pushed
the
patch-KubePersistentVolumeFillingUp-for-block-vol
branch
from
c1dd159
to
b86d50c
Compare
…volumeMode as block After [1] kubelet metrics `kubelet_volume_stats_available_bytes` and `kubelet_volume_stats_used_bytes` are set to 0 for all block PVC mounts. This causes the `KubePersistentVolumeFillingUp` alert to be fired immediately. Block volume mount stats can't really carry the `kubelet_volume_stats_used_bytes` because it is a raw storage device, not a file system. It is upto the workloads to deal with raw devices. This PR fixes the alert expression by testing `kubelet_volume_stats_used_bytes > 0` which prevents alert for block volume mounts. [1] kubernetes/kubernetes@b997e0e Signed-off-by: Arunprasad Rajkumar <arajkuma@redhat.com>
arajkumar
force-pushed
the
patch-KubePersistentVolumeFillingUp-for-block-vol
branch
from
b86d50c
to
b92f53d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After [1] kubelet metrics
kubelet_volume_stats_available_bytesandkubelet_volume_stats_used_bytesare set to 0 for all block PVC mounts. This causes theKubePersistentVolumeFillingUpalert to be fired immediately.Block volume mount stats can't really carry the
kubelet_volume_stats_used_bytesbecause it is a raw storage device, not a file system. It is upto the workloads to deal with raw devices.This PR fixes the alert expression by testing
kubelet_volume_stats_used_bytes > 0which prevents alert for block volume mounts.[1] kubernetes/kubernetes@b997e0e
Signed-off-by: Arunprasad Rajkumar arajkuma@redhat.com