dashboards: direct match namespace template where multi: false #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not change behavior at all. The unnecessary regex matcher can cause issues in conjunction with a new-ish prom-label-proxy feature (prometheus-community/prom-label-proxy#67). |
paulfantom
approved these changes
Nov 19, 2021
Some dashboards define a template variable `namespace` without the option to select multiple values. This commit sets `multi: false` explicitly and changes the `namespace` label matcher in queries in those dashboards from regex match (`=~`) to just match (`=`). Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f
force-pushed
the
dashboards-no-regexmatch-on-single-namespace
branch
from
1c3ad1f
to
ac0ef0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some dashboards define a template variable
namespacewithout theoption to select multiple values. This commit sets
multi: falseexplicitly and changes the
namespacelabel matcher in queries in thosedashboards from regex match (
=~) to just match (=).Signed-off-by: Jan Fajerski jfajersk@redhat.com