Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

remove self hosted etcd functionality #828

Merged

Conversation

rphillips
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 12, 2018
@@ -13,7 +13,6 @@ import (

"github.com/kubernetes-incubator/bootkube/pkg/bootkube"
"github.com/kubernetes-incubator/bootkube/pkg/recovery"
"github.com/kubernetes-incubator/bootkube/pkg/util/etcdutil"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is etcdutil used at all anymore?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove it too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. It is not. I'll remove the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 3c946bc

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 12, 2018
@ericchiang
Copy link
Contributor

ericchiang commented Jan 12, 2018 via email

@rphillips
Copy link
Contributor Author

Yes... I'll squash right after the tests get done.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 12, 2018
@rphillips
Copy link
Contributor Author

@ericchiang removed the unused vendor modules in a separate commit

Copy link
Contributor

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge on green

@rphillips
Copy link
Contributor Author

made a trivial tweak to the roadmap docs to remove self hosted etcd

@rphillips
Copy link
Contributor Author

coreosbot run e2e

@xiang90
Copy link
Contributor

xiang90 commented Jan 12, 2018

@rphillips

is hack/multi-node/bootkube-test-recovery-self-hosted-etcd also removed?

@rphillips
Copy link
Contributor Author

another good find... I removed that file and squashed it into the first commit.

@rphillips
Copy link
Contributor Author

coreosbot run e2e

@ericchiang
Copy link
Contributor

Hmm, API server never came back up

[148350.353894] golang[6]: === RUN   TestReboot
[148452.477483] golang[6]: --- PASS: TestReboot (102.12s)
[148452.478063] golang[6]: 	reboot_test.go:22: rebooting 2 nodes
[148452.478307] golang[6]: === RUN   TestSmoke
[148522.907035] golang[6]: E0112 20:09:13.912370    2124 nginx_workload.go:84] Error getting deployment nginx-1txrh: Get https://54.89.231.177:6443/apis/extensions/v1beta1/namespaces/bootkube-e2e-7d7e869a/deployments/nginx-1txrh: dial tcp 54.89.231.177:6443: getsockopt: connection refused
[148532.906674] golang[6]: E0112 20:09:23.912044    2124 nginx_workload.go:84] Error getting deployment nginx-1txrh: Get https://54.89.231.177:6443/apis/extensions/v1beta1/namespaces/bootkube-e2e-7d7e869a/deployments/nginx-1txrh: dial tcp 54.89.231.177:6443: getsockopt: connection refused
[148542.906786] golang[6]: E0112 20:09:33.912171    2124 nginx_workload.go:84] Error getting deployment nginx-1txrh: Get https://54.89.231.177:6443/apis/extensions/v1beta1/namespaces/bootkube-e2e-7d7e869a/deployments/nginx-1txrh: dial tcp 54.89.231.177:6443: getsockopt: connection refused

@rphillips
Copy link
Contributor Author

hmm. the build last night was green... I wonder if we should add this to the flaky issue.

@rphillips
Copy link
Contributor Author

coreosbot run e2e

@xiang90
Copy link
Contributor

xiang90 commented Jan 12, 2018

hmm. the build last night was green... I wonder if we should add this to the flaky issue.

let us add it.

@rphillips
Copy link
Contributor Author

added to #824

@rphillips
Copy link
Contributor Author

Same flake that Diego reported as well.

@rphillips rphillips merged commit 42f7a5c into kubernetes-retired:master Jan 12, 2018
@klausenbusk
Copy link
Contributor

It seems like a few things was forgotten in this PR, I have opened a new PR to fix that: #852

rphillips pushed a commit that referenced this pull request Jan 23, 2018
* pkg/asset: Remove self hosted etcd templates

It seems like this was forgotten in #828/8612599c651431248d1907b0625a4b523d0813e5

* hack/*: Remove self hosted etcd support

It seems like this was forgotten in #828/8612599c651431248d1907b0625a4b523d0813e5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants