remove self hosted etcd functionality #828
remove self hosted etcd functionality #828
Conversation
32608f4
to
4980c2c
Compare
@@ -13,7 +13,6 @@ import ( | |||
|
|||
"github.com/kubernetes-incubator/bootkube/pkg/bootkube" | |||
"github.com/kubernetes-incubator/bootkube/pkg/recovery" | |||
"github.com/kubernetes-incubator/bootkube/pkg/util/etcdutil" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is etcdutil used at all anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove it too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. It is not. I'll remove the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 3c946bc
Thanks. Can you squash?
…On Thu, Jan 11, 2018, 7:40 PM Ryan Phillips ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cmd/bootkube/recover.go
<#828 (comment)>
:
> @@ -13,7 +13,6 @@ import (
"github.com/kubernetes-incubator/bootkube/pkg/bootkube"
"github.com/kubernetes-incubator/bootkube/pkg/recovery"
- "github.com/kubernetes-incubator/bootkube/pkg/util/etcdutil"
fixed in 3c946bc
<3c946bc>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#828 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACO_XQ7A_zJsI4FeOglOnXpyqn70YgCVks5tJtQ9gaJpZM4RbwUm>
.
|
Yes... I'll squash right after the tests get done. |
3c946bc
to
583e36f
Compare
@ericchiang removed the unused vendor modules in a separate commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. merge on green
1710c95
to
ba82845
Compare
made a trivial tweak to the roadmap docs to remove self hosted etcd |
coreosbot run e2e |
is |
ba82845
to
f62e29e
Compare
another good find... I removed that file and squashed it into the first commit. |
coreosbot run e2e |
Hmm, API server never came back up
|
hmm. the build last night was green... I wonder if we should add this to the flaky issue. |
coreosbot run e2e |
let us add it. |
added to #824 |
Same flake that Diego reported as well. |
It seems like a few things was forgotten in this PR, I have opened a new PR to fix that: #852 |
No description provided.