Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to openshift, read ak from /root/.alibabacloud/credentials path. #572

Merged
merged 3 commits into from
Jan 17, 2022
Merged

Adapt to openshift, read ak from /root/.alibabacloud/credentials path. #572

merged 3 commits into from
Jan 17, 2022

Conversation

JiaoDean
Copy link
Contributor

@JiaoDean JiaoDean commented Dec 6, 2021

Adapt to openshift, read ak from /root/.alibabacloud/credentials path.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JiaoDean
To complete the pull request process, please assign fredkan after the PR has been reviewed.
You can assign the PR to them by writing /assign @fredkan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 9, 2021
@jsafrane
Copy link
Contributor

I tested this PR with OpenShift, I got this log line from Disk CSI driver:

time="2021-12-13T16:07:14Z" level=info msg="Get AK: use Credential AK"

Therefore I assume it does what it should do. I can provision/attach/detach/delete a volume with this. I let others comment on the code.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2022
@fredkan
Copy link
Member

fredkan commented Jan 14, 2022

/retest

1 similar comment
@fredkan
Copy link
Member

fredkan commented Jan 17, 2022

/retest

@fredkan
Update go.mod
9715358 
update grpc
@fredkan fredkan merged commit 9992a23 into kubernetes-sigs:master Jan 17, 2022
@jsafrane jsafrane mentioned this pull request Jan 20, 2022
Merged
@jsafrane jsafrane mentioned this pull request Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredkan fredkan Awaiting requested review from fredkan

@xianlubird xianlubird Awaiting requested review from xianlubird

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JiaoDean @k8s-ci-robot @jsafrane @fredkan