Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make OpenAPIConfig works #381

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@jeremyxu2010
Copy link
Contributor

commented Jul 21, 2019

I notice wrong golang struct coping causes OpenAPIConfig not working, so I fixed it. see #380

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2019

Welcome @jeremyxu2010!

It looks like this is your first PR to kubernetes-incubator/apiserver-builder-alpha 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-incubator/apiserver-builder-alpha has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

aggregatedAPIServerConfig.RecommendedConfig.Config.OpenAPIConfig = genericapiserver.DefaultOpenAPIConfig(GetOpenApiDefinition, openapinamer.NewDefinitionNamer(builders.Scheme))
aggregatedAPIServerConfig.RecommendedConfig.Config.OpenAPIConfig.Info.Title = title
aggregatedAPIServerConfig.RecommendedConfig.Config.OpenAPIConfig.Info.Version = version

genericConfig := aggregatedAPIServerConfig.RecommendedConfig.Config

This comment has been minimized.

Copy link
@yue9944882

yue9944882 Jul 22, 2019

Contributor
Suggested change
genericConfig := aggregatedAPIServerConfig.RecommendedConfig.Config
genericConfig := &aggregatedAPIServerConfig.RecommendedConfig.Config

thank you for fixing this. how you think about another pass? @jeremyxu2010

This comment has been minimized.

Copy link
@jeremyxu2010

jeremyxu2010 Jul 22, 2019

Author Contributor

done as you suggested @yue9944882

@yue9944882

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

/kind bug

@jeremyxu2010 jeremyxu2010 force-pushed the jeremyxu2010:master branch from 0a38400 to 10aa44b Jul 22, 2019

@jeremyxu2010 jeremyxu2010 force-pushed the jeremyxu2010:master branch from 10aa44b to 6dfbbb5 Jul 22, 2019

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Jul 22, 2019

@yue9944882

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9c776ce into kubernetes-sigs:master Jul 22, 2019

2 of 3 checks passed

tide Not mergeable. Needs approved, lgtm labels.
Details
cla/linuxfoundation jeremyxu2010 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.