Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade controller-runtime #1023

Open
wants to merge 3 commits into
base: master
from

Conversation

@rifelpet
Copy link
Contributor

rifelpet commented Sep 13, 2019

We've been experiencing some controller bugs where the ALB ingress controller isn't detecting certain changes to ingress annotations. We'll update an ingress annotation and the ALB ingress controller isn't notified about it until the ingress is then updated a second time.

I'm going to try upgrading the controller runtime (and as a result, client-go) to see if that helps. There are breaking changes in the Informers (kubernetes-sigs/controller-runtime#267) that I haven't had an opportunity to fix. If someone wants to step in and fix the remaining issues, feel free. Otherwise I'm hoping to get to it sometime soon.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 13, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rifelpet
To complete the pull request process, please assign m00nf1sh
You can assign the PR to them by writing /assign @m00nf1sh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from M00nF1sh and micahhausler Sep 13, 2019
@rifelpet rifelpet force-pushed the rifelpet:cr-0.2.0 branch from e7af992 to 2b159c8 Sep 13, 2019
@M00nF1sh

This comment has been minimized.

Copy link
Collaborator

M00nF1sh commented Sep 13, 2019

i think it might due to the annotation is parsed separately than the reconcile. (this problem don't exists in V2 though :D). a simple fix(without hard changes) should be force parse annotations before each reconcile :D

rifelpet added 3 commits Sep 5, 2019
@rifelpet rifelpet force-pushed the rifelpet:cr-0.2.0 branch from 34113e1 to 04f74a9 Sep 13, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 13, 2019

@rifelpet: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-aws-alb-ingress-controller-lint 04f74a9 link /test pull-aws-alb-ingress-controller-lint
pull-aws-alb-ingress-controller-unit-test 04f74a9 link /test pull-aws-alb-ingress-controller-unit-test
pull-aws-alb-ingress-controller-e2e-test 04f74a9 link /test pull-aws-alb-ingress-controller-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rifelpet

This comment has been minimized.

Copy link
Contributor Author

rifelpet commented Sep 13, 2019

Based on the log output and my understanding of how controller-runtime works, it seemed to me that the EventHandler wasn't being called during the first ingress update. I may be able to test your v2 implementation soon. It looks like your v2 still uses the controller-runtime 0.1.0, so I should be able to tell whether this issue is fixed or not 👍 regardless I think it would be good to get onto CR 0.2.0

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Dec 12, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 12, 2019

@rifelpet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 12, 2020

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.