Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UT failure due to coverall #915

Merged
merged 1 commit into from Apr 10, 2019
Merged

Conversation

@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Apr 9, 2019

Fix UT failure due to coverall by

  1. upgrade coveralls to the newest version to report serviceName without serviceJobID.
  2. avoid an hidden prow environment variable BUILD_NUMBER be reported as serviceJobID(will cause 500x)
@k8s-ci-robot k8s-ci-robot requested a review from bigkraig Apr 9, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@M00nF1sh M00nF1sh force-pushed the M00nF1sh:debug_ut branch 3 times, most recently from a5c310e to 20cebea Apr 9, 2019
@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Apr 9, 2019
@M00nF1sh M00nF1sh force-pushed the M00nF1sh:debug_ut branch 3 times, most recently from 415cf67 to 053d54a Apr 10, 2019
@M00nF1sh M00nF1sh changed the title debug ut failure Fix UT failure due to coverall Apr 10, 2019
@M00nF1sh M00nF1sh force-pushed the M00nF1sh:debug_ut branch from 053d54a to e7656b6 Apr 10, 2019
@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Apr 10, 2019
@bigkraig

This comment has been minimized.

Copy link
Member

bigkraig commented Apr 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 42f0de3 into kubernetes-sigs:master Apr 10, 2019
6 of 7 checks passed
6 of 7 checks passed
tide Not mergeable.
Details
cla/linuxfoundation M00nF1sh authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on debug_ut at 45.854%
Details
pull-aws-alb-ingress-controller-e2e-test Job succeeded.
Details
pull-aws-alb-ingress-controller-lint Job succeeded.
Details
pull-aws-alb-ingress-controller-unit-test Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.